From 5a474c89014cae6b94c2809aa2ed91660c57a23c Mon Sep 17 00:00:00 2001 From: Shreyaav18 Date: Sun, 1 Mar 2026 02:17:47 +0530 Subject: [PATCH 1/3] fix: add else branch in DatasetList.get_ids() for delayed=True --- gliderpy/fetchers.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gliderpy/fetchers.py b/gliderpy/fetchers.py index 90e832f..c577cf8 100644 --- a/gliderpy/fetchers.py +++ b/gliderpy/fetchers.py @@ -253,4 +253,6 @@ def get_ids(self: "DatasetList") -> list: for dataset_id in dataset_ids if not dataset_id.endswith("-delayed") ] + else: + self.dataset_ids = dataset_ids return self.dataset_ids From 306b21fdeceb1c81792d627e8934e51ae96e393a Mon Sep 17 00:00:00 2001 From: Shreyaav18 Date: Sun, 1 Mar 2026 02:50:44 +0530 Subject: [PATCH 2/3] fix: correct delayed dataset filtering in DatasetList.get_ids --- gliderpy/fetchers.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gliderpy/fetchers.py b/gliderpy/fetchers.py index c577cf8..9cbd56d 100644 --- a/gliderpy/fetchers.py +++ b/gliderpy/fetchers.py @@ -234,6 +234,7 @@ def __init__( ) self.search_for = search_for self.delayed = delayed + self.dataset_ids: OptionalList = None def get_ids(self: "DatasetList") -> list: """Return the allDatasets list for the glider server.""" @@ -248,11 +249,10 @@ def get_ids(self: "DatasetList") -> list: dataset_ids = self.e.to_pandas()["datasetID"].to_list() dataset_ids.remove("allDatasets") if not self.delayed: - self.dataset_ids = [ + dataset_ids = [ dataset_id for dataset_id in dataset_ids if not dataset_id.endswith("-delayed") ] - else: - self.dataset_ids = dataset_ids + self.dataset_ids = dataset_ids return self.dataset_ids From 40c9bc48b56f3feaf6c6920145bbcad9467f399d Mon Sep 17 00:00:00 2001 From: Shreyaav18 Date: Sun, 1 Mar 2026 21:05:12 +0530 Subject: [PATCH 3/3] fix lint issues --- gliderpy/fetchers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gliderpy/fetchers.py b/gliderpy/fetchers.py index 9cbd56d..13d55d8 100644 --- a/gliderpy/fetchers.py +++ b/gliderpy/fetchers.py @@ -249,10 +249,10 @@ def get_ids(self: "DatasetList") -> list: dataset_ids = self.e.to_pandas()["datasetID"].to_list() dataset_ids.remove("allDatasets") if not self.delayed: - dataset_ids = [ + dataset_ids = [ dataset_id for dataset_id in dataset_ids if not dataset_id.endswith("-delayed") ] - self.dataset_ids = dataset_ids + self.dataset_ids = dataset_ids return self.dataset_ids