You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lack of signing on Windows means that when a binary is run for the first time and tries to access networking it gets Windows Defender Firewall warning with "Publisher: Unknown":
Screenshot from dev instance in Brave (without signing done by Brave, to illustrate the problem)
My guess is that over time, MS Windows will get more and more strict, just like macOS did in recent years.
Solution: sign windows binaries
ipfs-desktop has some signing keys set up, but I am not sure how reusable those are (TBD if we need to generate unique pair for each package, or can sign everything with the same pair)
Adding sign-windows job after sign-macos (sequentially) should be easy and fast enough
(we can parallelize them if needed, but given how long macos signing takes, the difference will be minimal)
Problem
Lack of signing on Windows means that when a binary is run for the first time and tries to access networking it gets Windows Defender Firewall warning with "Publisher: Unknown":
My guess is that over time, MS Windows will get more and more strict, just like macOS did in recent years.
Solution: sign windows binaries
sign-windowsjob aftersign-macos(sequentially) should be easy and fast enough(we can parallelize them if needed, but given how long macos signing takes, the difference will be minimal)