-
Notifications
You must be signed in to change notification settings - Fork 28
Batch is not thread safe #47
Copy link
Copy link
Open
Labels
help wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing feature
Metadata
Metadata
Assignees
Labels
help wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing feature
Type
Fields
Give feedbackNo fields configured for issues without a type.
Looking at batch code, it using an
activeCommits intandsize intcounters very liberally all over the place. Calling Add(), at the same time asCommit()seems likely to trigger weird side effects: i.e. size reset to 0 when it should not, oractiveCommitspotentially going on the negative.