Skip to content

bindEditorHotkeys: single-key bindings ignore modifier state (⌘K triggers split) #20

Description

@ziqiangai

In src/ui/hotkeys.ts, the keydown else-if chain matches e.code for Space/K/Q/W/I/O/arrows before any modifier check — only the KeyZ branch tests metaKey/ctrlKey. So while the editor is mounted with hotkeys enabled:

  • ⌘K (browser omnibox/search) splits the clip at the playhead and preventDefaults the browser shortcut
  • Ctrl+W performs a trimRight just before the tab closes
  • Any other chord containing a bound letter fires the bare-key action

Suggested fix: guard the single-key branches with !e.metaKey && !e.ctrlKey && !e.altKey (Shift stays allowed — arrows already use it for the big frame step).

Found while integrating 0.8.5 into iplex (ipmotionmc/iplex#1810).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions