hmm...

[bbroder-uji]

cpp-algorand-sdk/algorand.cpp

Line 536 in 47113f7

int Transaction::key_count() const {

fixed type schema in an ancillary function will eventually fall out of sync with the real schema presumably defined somewhere else?

[jannotti]

If this code falls out of sync (say a field is added to an existing transaction type) then it certainly won't add such a field. So that field won't be present, and the key_count will still be correct.

This isn't counting all the fields that might be in a transaction of a given type, but the fields that are actually set in this transaction. Algorand elides "zero" values in most cases, so this function if counting which field are non-zero.

[bbroder-uji]

ok yes I see and if a transaction schema was altered (say deprecation of a field), transaction code like this using that schema would have to be altered anyway. The txn schema feels somehow unversioned but I get that this would complicate things significantly.

…

On Fri, Dec 3, 2021 at 12:38 PM John Jannotti ***@***.***> wrote: If this code falls out of sync (say a field is added to an existing transaction type) then it certainly won't add such a field. So that field won't be present, and the key_count will still be correct. This isn't counting all the fields that might be in a transaction of a given type, but the fields that are actually set in *this* transaction. Algorand elides "zero" values in most cases, so this function if counting which field are non-zero. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWBAJUKLS74VBP36IMGQATTUPD57VANCNFSM5JHQ465A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.