Gtk4 - example

[d3im]

Trying to modify PyGobject example for Gtk4
I can't get over this line - get XID of window since widget lacks window property

self.mpv = mpv.MPV(wid=str(widget.get_property("window").get_xid()))

TypeError: object of type `GtkFrame' does not have property `window'

[llyram]

did you find a solution?

[bscubed]

I'm also in need of a solution. As of now, I've managed to render in GTK4 using OpenGL with this gist, but it's very buggy when resizing. Any workarounds for native MPV?

[llyram]

This worked for me

self.mpv = mpv.MPV(wid=str(GdkX11.X11Surface.get_xid(self.get_surface())))

[trin94]

@d3im You are trying to access a X11 window function on GTK 4.0. This will definitely not work on Wayland, too. And GTK 4.0's main focus is Wayland. There are even plans to drop X11 support in GTK 5.0: https://www.phoronix.com/scan.php?page=news_item&px=GTK5-Might-Drop-X11

The render context API should be the way to go. I have experimented with Qt 5 and Qt 6: https://github.com/trin94/qtquick-mpv
Maybe that helps you to get started 😃 The concepts should be similar for GTK and Qt.

@bscubed Consider using

self._ctx.render(
    flip_y=True,
    opengl_fbo={'w': width, 'h': height, 'fbo': fbo},
    block_for_target_time=False,
)

Documentation is located here: https://github.com/mpv-player/mpv/blob/master/libmpv/render.h#L300-L316=

As stated, you may want to set video-timing-offset to 0 additionally.

[trin94]

I've created a poc: https://github.com/trin94/python-mpv-gtk4

[jaseg]

I agree with @trin94 here. The legacy way of rendering video into an UI component was to get a display-manager-level handle to the UI component from the UI toolkit (e.g. an X11 window ID) and hand that to libmpv. The disadvantage of this is that both your app and libmpv have to have separate code paths for every display manager out there. Beyond the issue of Linuxes now commonly having either one of X11 or Wayland, this approach also doesn't work on Windows or Mac.

Using OpenGL via render contexts really is the clean solution to this. OpenGL here is a shared API that will work on all platforms, including Wayland and Windows. While it seems more complicated at first, it will make cross-platform compatibility much easier in the long run.

@trin94 Is the URL of your example repo stable? I would like to link it in the README.

[bscubed]

Thanks for the detailed write-up and example repo, @trin94 . Turns out that the buggy resizing wasn't a product of MPV or OpenGL, but a GTK-specific bug that I've sorted out. I'll adjust my OpenGL implementation to include bits from your example, as it looks really well written and includes checks for EGL and GLX.

This definitely seems like the clean solution for GTK going forward.

[trin94]

@jaseg Yes, the url is stable. You/I can also make a gist out of it so that we can link it in the README 👍 Whatever you chose, we should also make people aware of the thing with the block_for_target_time=False and video-timing-offset=0: #222 (comment). It can then summarize (and possibly replace) PyGObject embedding and Using OpenGL from PyGObject from the README.

[trin94]

Hi @jaseg,

I'd be happy to add the gtk4 example to your project. However, I think there's too much code to put it into the README. What about an examples folder in the root of this repository? Just let me know if that's okay with you or if you prefer a different solution and I'll prepare a PR 😃

[trin94]

I have archived the example repo under https://github.com/trin94/python-mpv-gtk4 with the intention to remove it in a couple of weeks. As a replacement, I've created a gist: https://gist.github.com/trin94/3381395adc8b2c3fea81a38b9a385369

@jaseg
Feel free to either copy and adapt or link it directly in the README 😃