From 8c0923fc4586b5ac55c6f1fb2b38dfe29cdfa43f Mon Sep 17 00:00:00 2001 From: sisyphus-jasp Date: Fri, 27 Feb 2026 06:17:29 +0100 Subject: [PATCH] [jaspQualityControl] Fix legend text cutoff and expand abbreviated x-axis labels in... --- .claude/CLAUDE.md | 33 +++ R/msaGaugeRR.R | 6 +- ...analysis-1-figure-1-bias-histogram.new.svg | 253 ++++++++++++++++++ .../msaType1Gauge/1-bias-histogram.new.svg | 253 ++++++++++++++++++ .../msaType1Gauge/2-bias-histogram.new.svg | 247 +++++++++++++++++ .../msaType1Gauge/3-bias-histogram.new.svg | 248 +++++++++++++++++ .../msaType1Gauge/4-bias-histogram.new.svg | 176 ++++++++++++ 7 files changed, 1213 insertions(+), 3 deletions(-) create mode 100644 tests/testthat/_snaps/example-Type1InstrumentCapability/analysis-1-figure-1-bias-histogram.new.svg create mode 100644 tests/testthat/_snaps/msaType1Gauge/1-bias-histogram.new.svg create mode 100644 tests/testthat/_snaps/msaType1Gauge/2-bias-histogram.new.svg create mode 100644 tests/testthat/_snaps/msaType1Gauge/3-bias-histogram.new.svg create mode 100644 tests/testthat/_snaps/msaType1Gauge/4-bias-histogram.new.svg diff --git a/.claude/CLAUDE.md b/.claude/CLAUDE.md index 27bd9cec..3d272557 100644 --- a/.claude/CLAUDE.md +++ b/.claude/CLAUDE.md @@ -231,3 +231,36 @@ After `runAnalysis()`, check: - Use `createJaspTable()`, `createJaspPlot()`, `createJaspHtml()` for output elements - Always set `$dependOn()` for proper caching and state management - Use containers for grouping related elements, state objects for reusing computed results + +## Container Environment (overrides Session Setup section above) + +This is a **headless Docker container**. There is no interactive user. + +### MANDATORY FIRST ACTION — R Session Connection + +Before doing ANYTHING else (before reading code, before exploring the repo), +you MUST connect to the pre-started R session: + +1. Call `list_r_sessions` to discover available sessions. +2. Call `select_r_session` to connect to the listed session. +3. Only then proceed with the workflow. + +If `list_r_sessions` returns empty, the background R session failed to start. +Fall back to Bash for R execution. Do NOT spend more than 2 turns debugging. + +This step is NOT optional. Without it, `btw_tool_run_r` will fail. + +### Other container rules + +- `session_startup.R` is NOT relevant here — ignore references to it. +- Do NOT run any git commands (the outer orchestrator handles git). + +## Compact Instructions + +When context is compacted, preserve: +- Current workflow stage (from /workspace/.openclaw-run/current_stage) +- Implementation plan (from /workspace/.openclaw-run/PLAN.md) +- The module name and original task description +- What git changes have been made so far + +After compaction, re-read /workspace/.openclaw-run/RECOVERY.md to re-orient. diff --git a/R/msaGaugeRR.R b/R/msaGaugeRR.R index 3452c86a..ee6cfabc 100644 --- a/R/msaGaugeRR.R +++ b/R/msaGaugeRR.R @@ -687,14 +687,14 @@ msaGaugeRR <- function(jaspResults, dataset, options, ...) { return(list(study = c(round(studyVar/max(studyVar) * 100,2))[1], tol = c(round(studyVar / options[["toleranceValue"]] * 100,2))[1])) if (options[["varianceComponentsGraph"]]) { - plot <- createJaspPlot(title = gettext("Components of variation"), width = 850, height = 500) + plot <- createJaspPlot(title = gettext("Components of variation"), width = 950, height = 500) plot$dependOn(c("varianceComponentsGraph", "report")) plot$plotObject <- p anovaTables[['VarCompGraph']] <- plot } } else { - plot <- createJaspPlot(title = gettext("Components of variation"), width = 850, height = 500) + plot <- createJaspPlot(title = gettext("Components of variation"), width = 950, height = 500) plot$dependOn(c("gaugeVarCompGraph", "report")) anovaTables[['anovaTable1']] <- anovaTable1 @@ -904,7 +904,7 @@ msaGaugeRR <- function(jaspResults, dataset, options, ...) { } .gaugeVarCompGraph <- function(percentContributionValues, studyVariationValues, percentToleranceValues, Type3 = FALSE) { - sources <- gettext(c('Gauge r&R', 'Repeat', 'Reprod', 'Part-to-part')) + sources <- gettext(c('Total Gauge R&R', 'Repeatability', 'Reproducibility', 'Part-to-Part')) if (!all(is.na(percentToleranceValues))) { references <- gettextf(c('%% Contribution', '%% Study variation', '%% Tolerance')) values <- c(percentContributionValues, studyVariationValues, percentToleranceValues) diff --git a/tests/testthat/_snaps/example-Type1InstrumentCapability/analysis-1-figure-1-bias-histogram.new.svg b/tests/testthat/_snaps/example-Type1InstrumentCapability/analysis-1-figure-1-bias-histogram.new.svg new file mode 100644 index 00000000..0b696f60 --- /dev/null +++ b/tests/testthat/_snaps/example-Type1InstrumentCapability/analysis-1-figure-1-bias-histogram.new.svg @@ -0,0 +1,253 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +0 +5 +10 +15 + + + + + + + + + + + +-5.5 +-5.0 +-4.5 +-4.0 +-3.5 +-3.0 +jaspColumn1 +Count + + + + + + + + + + + + + + +Mean +Mean - 3s +Mean + 3s +Reference +Ref. - 0.10 * tol. +Ref. + 0.10 * tol. +analysis-1_figure-1_bias-histogram + + diff --git a/tests/testthat/_snaps/msaType1Gauge/1-bias-histogram.new.svg b/tests/testthat/_snaps/msaType1Gauge/1-bias-histogram.new.svg new file mode 100644 index 00000000..f28037c6 --- /dev/null +++ b/tests/testthat/_snaps/msaType1Gauge/1-bias-histogram.new.svg @@ -0,0 +1,253 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +0 +5 +10 +15 + + + + + + + + + + + +-5.5 +-5.0 +-4.5 +-4.0 +-3.5 +-3.0 +dm +Count + + + + + + + + + + + + + + +Mean +Mean - 3s +Mean + 3s +Reference +Ref. - 0.10 * tol. +Ref. + 0.10 * tol. +1_bias-histogram + + diff --git a/tests/testthat/_snaps/msaType1Gauge/2-bias-histogram.new.svg b/tests/testthat/_snaps/msaType1Gauge/2-bias-histogram.new.svg new file mode 100644 index 00000000..0e215eaf --- /dev/null +++ b/tests/testthat/_snaps/msaType1Gauge/2-bias-histogram.new.svg @@ -0,0 +1,247 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +0 +5 +10 +15 + + + + + + + + + + +-5.0 +-4.5 +-4.0 +-3.5 +-3.0 +dm +Count + + + + + + + + + + + + + + +Mean +Mean - 2s +Mean + 2s +Reference +Ref. - 0.07 * tol. +Ref. + 0.07 * tol. +2_bias-histogram + + diff --git a/tests/testthat/_snaps/msaType1Gauge/3-bias-histogram.new.svg b/tests/testthat/_snaps/msaType1Gauge/3-bias-histogram.new.svg new file mode 100644 index 00000000..e07d4ebb --- /dev/null +++ b/tests/testthat/_snaps/msaType1Gauge/3-bias-histogram.new.svg @@ -0,0 +1,248 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +0 +5 +10 + + + + + + + + + + +-5.5 +-5.0 +-4.5 +-4.0 +-3.5 +-3.0 +dmMissing1 +Count + + + + + + + + + + + + + + +Mean +Mean - 3s +Mean + 3s +Reference +Ref. - 0.10 * tol. +Ref. + 0.10 * tol. +3_bias-histogram + + diff --git a/tests/testthat/_snaps/msaType1Gauge/4-bias-histogram.new.svg b/tests/testthat/_snaps/msaType1Gauge/4-bias-histogram.new.svg new file mode 100644 index 00000000..3c9b9602 --- /dev/null +++ b/tests/testthat/_snaps/msaType1Gauge/4-bias-histogram.new.svg @@ -0,0 +1,176 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +0 +5 +10 + + + + + + + + + + +-4.6 +-4.4 +-4.2 +-4.0 +-3.8 +-3.6 +dmMissing25 +Count + + + + + + + + + + + + + + +Mean +Mean - 3s +Mean + 3s +Reference +Ref. - 0.10 * tol. +Ref. + 0.10 * tol. +4_bias-histogram + +