Compatibility issue with xskills: endless filling when pouring into molds

[AurelieMio19]

When using Xskills most molds have a reduced amount of metal needed to fill them (all of them except ingot). For any of theses mold the pouring is looping when it reach the maximum. It goes up until the maximum amount (<100), then it start again at 0. And since it's almost impossible to be precise when pouring, it's impossible to cast anything.

I suppose Smithing + tries to fill the mold until 100 but it can't so it loops.

2 others players have the same problem in the comment of Xskills, . I don't know which mod need an update to avoid this incompatibility.

[jayu-vs]

It might be xskills doing things in an unexpected way here, because I only alter the required units in the block entity not in the block attributes, as that is less dynamic. If xskills is grabbing or changing that, then this could be an issue I guess.

[jayu-vs]

Maybe fixed in dev build but haven't tested yet.

[pandabear41]

It is not fixed. What I think is happening from the code is xskills is adding x% of bits to the mold every pourable step, but if the mold is full it will refund the overage to the held pourable item assuming it is 100 units to fill a mold. SmithingPlus is modifying the max units of the mold itself. So they conflict and dupe metal.
https://github.com/Xandu93/VSMods/blob/master/mods/xskills/src/Skills/Metalworking.cs#L506-L508

[jayu-vs]

It is not fixed. What I think is happening from the code is xskills is adding x% of bits to the mold every pourable step, but if the mold is full it will refund the overage to the held pourable item assuming it is 100 units to fill a mold. SmithingPlus is modifying the max units of the mold itself. So they conflict and dupe metal. https://github.com/Xandu93/VSMods/blob/master/mods/xskills/src/Skills/Metalworking.cs#L506-L508

If XSkills always assumes 100 is the max, the fault is with XSkills.