Skip to content

Hwyla mod-name tail provider disappears when Fluidlogged API is enabled #304

Description

@bartoszkiljanski

Describe the bug
With Fluidlogged API enabled, Hwyla does not display the originating mod name for normal blocks.

To Reproduce

  1. Launch Minecraft 1.12.2 using Cleanroom with Hwyla and Fluidlogged API.
  2. Look at a normal vanilla or modded block.
  3. Observe that the block name is displayed, but the originating mod name is missing.
  4. Run /dumphandlers.
  5. Observe that HUDHandlerBlocks is missing for net.minecraft.block.Block under TAIL BLOCK PROVIDERS.
  6. Disable Fluidlogged API and restart the same instance.
  7. Look at the same block.
  8. Observe that the mod-origin line is displayed again.

Expected behavior
Fluidlogged API's Hwyla compatibility transformer should preserve Hwyla's
generic block tail provider:

net.minecraft.block.Block
mcp.mobius.waila.addons.core.HUDHandlerBlocks

Additional context

With Fluidlogged API enabled:

TAIL BLOCK PROVIDERS

  • net.minecraftforge.fluids.IFluidBlock

    • mcp.mobius.waila.addons.core.HUDHandlerFluids
  • mcjty.lib.blocks.BaseBlock

    • mcjty.lib.compat.waila.WailaCompatibility

With Fluidlogged API disabled:

TAIL BLOCK PROVIDERS

  • net.minecraft.block.Block

    • mcp.mobius.waila.addons.core.HUDHandlerBlocks
  • net.minecraft.block.BlockLiquid

    • mcp.mobius.waila.addons.core.HUDHandlerFluids
  • net.minecraftforge.fluids.IFluidBlock

    • mcp.mobius.waila.addons.core.HUDHandlerFluids
  • mcjty.lib.blocks.BaseBlock

    • mcjty.lib.compat.waila.WailaCompatibility

Environment

Minecraft: 1.12.2
Loader: Cleanroom 0.5.17-alpha
Launcher: Prism Launcher
Hwyla: 1.8.26-B41_1.12.2
Fluidlogged API: 3.3.3
Rolled-back Fluidlogged API version also tested: (All 3.x.x versions. Below crashes my modpack and I can't test)
Java version: 25
Waila Harvestability: 1.1.12
SonarCore: 5.0.19-20
Full modpack rather than a minimal test instance

Metadata

Metadata

Assignees

Labels

bugSomething isn't working as intendedincompatibilityThis issue relates to another mod

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions