Refresh settings after db change

[pedrocasado]

Is there any way to clear the cache or reload settings from db?

I switch between connections, but after that the settings classes doesn't update, even after reload() or resetToDefaultValues;

protected function execute(InputInterface $input, OutputInterface $output): int
{
    foreach ($this->tenantManager->findActiveTenants() as $tenant) {
        $this->doctrine->getManager('default')->getConnection()->selectDatabase($tenant);
        $this->doctrine->getManager('default')->clear();

        $appSettings = $this->settingsManager->get(AppSettings::class);
        
        $appSettings = $this->settingsManager->reload($appSettings);
        $this->settingsManager->resetToDefaultValues($appSettings);
        
        $output->writeln($appSettings->instanceRecipientId);
    }

    return 0;
}

This is how i change db:

public function selectDatabase(Tenant $tenant): void
{
    if ($this->isConnected()) {
        $this->close();
    }

    $params = $this->getParams();

    $params['dbname'] = $tenant->getDatabaseName();
    $params['host'] = $tenant->getDatabaseHost();
    $params['user'] = $tenant->getDatabaseUser();
    $params['password'] = $tenant->getDatabasePassword();

    parent::__construct($params, $this->driver, $this->_config);
}

I see that this looks like its related to cache. Maybe we could add a ->clearCache() method in ORMStorageAdapter?

//Check if we already have the entity in the cache
if (isset($this->cache[$entityClass][$key])) {
    return $this->cache[$entityClass][$key];
}

[jbtronics]

In general, I think switching the database connection is not ideal at all and will also probably cause problems with doctrine in other places...
But I think the problem you have is caused by the high-level cache, which caches on the hydrated settings objects level.
You can either disable this caching completely, or use the invalidateData method, to invalidate the cache for individual settings classes.

The cache snippet you have shown, is only for the FileStorage Adapters, if you are using doctrine, then this works differently (and doctrine is the cache), and you probably need to refresh the underlying doctrine entities or clear the whole entity manager...

[pedrocasado]

Looks like doctrine does handle switching database normally... I think there's no problem here, as most multi-tenancy systems does that. AFAIK the $this->doctrine->getManager('default')->clear(); handles it.

I've added an ignoreCache param to the reload() method, so i can then refetch settings data from db. What do you think about this approach? pedrocasado@a706a98

foreach ($this->tenantManager->findActiveTenants() as $tenant) {
    $this->doctrine->getManager('default')->getConnection()->selectDatabase($tenant);
    $this->doctrine->getManager('default')->clear();

    $appSettings = $this->settingsManager->get(AppSettings::class);

    $appSettings = $this->settingsManager->reload(
        settings: $appSettings,
        cascade: true,
        ignoreCache: true
    );

    $output->writeln($appSettings->recipientId);
}

Sorry if i miss something in the code, but this fix worked. If you think there's a path here, i can improve the code.

[pedrocasado]

Code sample: https://github.com/pedrocasado/reload-settings