HttpClient #10

msasanmh · 2023-05-24T17:19:21Z

msasanmh
May 24, 2023

Hi, I have a question in mind, do you have any plan to use HttpClient instead of HttpWebRequest?
I'm talking about this line:

RestWrapper/src/RestWrapper/RestRequest.cs

Line 426 in ac19d99

HttpWebRequest client = (HttpWebRequest)WebRequest.Create(Url);

Answered by jchristn

Jul 12, 2023

Hi @msasanmh I just completed the migration from HttpWebRequest to HttpClient in v3.0. I'd love to have you take a look and let me know if there are any issues!

Commit: 993a29f
NuGet: https://www.nuget.org/packages/RestWrapper/3.0.0

View full answer

jchristn · 2023-05-27T00:28:52Z

jchristn
May 27, 2023
Maintainer

Hi, I would like to, but I haven't found the time yet to migrate it. If it's something you'd be interested in tackling I'd love to take a PR on it!

0 replies

msasanmh · 2023-05-27T05:56:44Z

msasanmh
May 27, 2023
Author

Hi, I would like to, but I haven't found the time yet to migrate it. If it's something you'd be interested in tackling I'd love to take a PR on it!

Actually I've tried and it kinda worked, but I had some issues.
It couldn't satisfy me, I deleted all the modifications.
I really don't want to mess it up. :(

5 replies

jchristn Jul 12, 2023
Maintainer

Hi @msasanmh I just completed the migration from HttpWebRequest to HttpClient in v3.0. I'd love to have you take a look and let me know if there are any issues!

Commit: 993a29f
NuGet: https://www.nuget.org/packages/RestWrapper/3.0.0

Answer selected by msasanmh

msasanmh Jul 12, 2023
Author

Thank you 🙏 I'm gonna check it out and let you know.

msasanmh Jul 12, 2023
Author

@jchristn The last time you asked me to pull a pr, I used HttpClient but because of a website called http://neverssl.com I revert back to HttpWebRequest.

but now I tried other non ssl websites, all of them are ok, like:
http://info.cern.ch
http://www.grose.us

except http://neverssl.com, but HttpWebRequest can open even this website correctly.

Error:
"The byte stream was erroneous according to the character encoding that was declared. The character encoding declaration may be incorrect."

Conclusion:
Everything's OK except neverssl.com
Thank you for updating RestRequest.

jchristn Jul 12, 2023
Maintainer

Hi @msasanmh thanks! Interesting, I used the Test project with neverssl.com and it worked:

Command [? for help]: get
URL: [http://127.0.0.1:8000/] http://neverssl.com
REST Response
  Headers
  | Date: Wed, 12 Jul 2023 16:43:31 GMT
  | Server: Apache/2.4.57,()
  | Upgrade: h2,h2c
  | Connection: Upgrade,close
  | ETag: "f79-5e28b29d38e93"
  | Accept-Ranges: bytes
  | Vary: Accept-Encoding
  Content Type       : text/html; charset=UTF-8
  Status Code        : 200
  Status Description : OK
  Content Length     : 3961
  Time
  | Start (UTC)      : 2023-07-12 16:43:32
  | End (UTC)        : 2023-07-12 16:43:32
  | Total            : 409.97ms
  Data               : [stream]

Content:
<html>
        <head>
                <title>NeverSSL - Connecting ... </title>
                <style>
                body {
                        font-family: Montserrat, helvetica, arial, sans-serif;
                        font-size: 16x;
                        color: #444444;
                        margin: 0;
                }
                h2 {
                        font-weight: 700;

Thanks for taking a look! Cheers, Joel

msasanmh Jul 12, 2023
Author

Yeah, status code and content are ok, I was rendering it on browser using proxy server, I guess it's because this website doesn't have a meta tag for encoding, like: <meta charset="utf-8">.
it's nothing important anyway.
Thanks again.

Navigation Menu

Uh oh!

HttpClient #10

Uh oh!

{{title}}

Uh oh!

Replies: 2 comments 5 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Select a reply

Uh oh!

Uh oh!

HttpClient #10

Uh oh!

msasanmh May 24, 2023

Replies: 2 comments · 5 replies

Uh oh!

jchristn May 27, 2023 Maintainer

Uh oh!

msasanmh May 27, 2023 Author

Uh oh!

jchristn Jul 12, 2023 Maintainer

Uh oh!

msasanmh Jul 12, 2023 Author

Uh oh!

msasanmh Jul 12, 2023 Author

Uh oh!

jchristn Jul 12, 2023 Maintainer

Uh oh!

Uh oh!

msasanmh Jul 12, 2023 Author

msasanmh
May 24, 2023

Replies: 2 comments 5 replies

jchristn
May 27, 2023
Maintainer

msasanmh
May 27, 2023
Author

jchristn Jul 12, 2023
Maintainer

msasanmh Jul 12, 2023
Author

msasanmh Jul 12, 2023
Author

jchristn Jul 12, 2023
Maintainer

msasanmh Jul 12, 2023
Author