I noted that there is non consistency in the exit codes of packETHcli. On successful execution it returns non-zero (1), when incorrect parameters are provided it returns 0 or 7.
I would recommend to return 0 on successful execution (now it returns 1), then other (non-zero) values on error (or wrong parameter)
I noted that there is non consistency in the exit codes of packETHcli. On successful execution it returns non-zero (1), when incorrect parameters are provided it returns 0 or 7.
I would recommend to return 0 on successful execution (now it returns 1), then other (non-zero) values on error (or wrong parameter)