lazygit quits unexpectedly with message: Error: must be run inside a git repository

[vbauerster]

To reproduce, there must be some bare repository with at least one submodule in it. Let say bare repo is in ~/.git_dotfiles, then invoke lazygit like lazygit --git-dir=~/.git_dotfiles --work-tree=~/. Navigate to submodule view then enter any submodule with enter key, finally press esc to go back to main view.

Outcome is lazygit quits unexpectedly with following message:

2020/12/17 13:21:29 Error: must be run inside a git repository

❯ lazygit --version
commit=, build date=, build source=homebrew, version=0.23.7, os=darwin, arch=amd64

[BitCalSaul]

this still happens in 0.62.

[xooooooooox]

Root cause, for anyone hitting this with yadm/vcsh-style setups: the --git-dir/--work-tree flags only survive as the GIT_DIR/GIT_WORK_TREE env vars. Entering a submodule clears them (necessarily), but the repo-path stack only records the working directory — so escape restores the cwd and nothing restores the env vars, and git rev-parse then fails in a worktree whose git dir can't be discovered from the path. If a repo happens to exist above the worktree, escape instead silently switches into that wrong repo.

Opened #5904, which makes the repo-path stack record the env vars alongside the path and restore them on the way back, with an integration test covering the --git-dir/--work-tree round-trip.