Skip to content

Remove legacy customization icon assemblies for Revit 2027 / .NET 10#102

Merged
johnpierson merged 4 commits into
masterfrom
copilot/replace-binaryformatter-usage
May 19, 2026
Merged

Remove legacy customization icon assemblies for Revit 2027 / .NET 10#102
johnpierson merged 4 commits into
masterfrom
copilot/replace-binaryformatter-usage

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

Revit 2027 moves Rhythm onto .NET 10, where the legacy resource loading path behind the shipped customization/icon DLLs throws at runtime. The most visible failure was Batch.UpgradeFamilies, but the underlying issue affected any node path that loaded those assemblies.

  • What changed

    • Removed deploy/2027/RhythmCore.customization.dll and deploy/2027/RhythmRevit.customization.dll
    • Stopped generating customization/icon DLLs for Revit 2027 in RhythmCore and RhythmRevit
    • Updated RhythmViewExtension to skip downloading those DLLs for 2027 and delete stale local copies if present
  • Runtime behavior

    • Revit 2027 continues to load the main node libraries and customization XML
    • Legacy icon assemblies are no longer part of the 2027 package/runtime path
    • This avoids the .NET 10 BinaryFormatter failure without changing node execution logic
  • Legacy serialization cleanup

    • Removed obsolete exception serialization members tied to legacy formatter-based patterns
    • Removed BinaryFormatter-specific text from the resx scaffolding/helpers and checked-in resx comments
  • Documentation

    • Added a short README note that Revit 2027 no longer ships the legacy customization DLLs

Example of the packaging/build change:

<Target Name="CreateNodeIcons" AfterTargets="PostBuildEvent" Condition="'$(RevitVersion)' != '2027'">

And the runtime guard in the view extension:

if (ShouldSkipCustomizationDll(version))
{
    return;
}

Copilot AI linked an issue May 19, 2026 that may be closed by this pull request
7 tasks
Copilot AI and others added 3 commits May 19, 2026 15:46
Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/ee88158a-2677-4160-9b83-d2b98172a9ad

Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/ee88158a-2677-4160-9b83-d2b98172a9ad

Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace BinaryFormatter usage for Revit 2027 with .NET 10 Remove legacy customization icon assemblies for Revit 2027 / .NET 10 May 19, 2026
Copilot AI requested a review from johnpierson May 19, 2026 15:52
@johnpierson johnpierson marked this pull request as ready for review May 19, 2026 15:54
@johnpierson johnpierson merged commit ba25258 into master May 19, 2026
1 check passed
@johnpierson johnpierson deleted the copilot/replace-binaryformatter-usage branch May 19, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revit 2027 / .NET 10 – Replace BinaryFormatter Usage

2 participants