Remove legacy customization icon assemblies for Revit 2027 / .NET 10#102
Merged
Conversation
7 tasks
Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/ee88158a-2677-4160-9b83-d2b98172a9ad Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/ee88158a-2677-4160-9b83-d2b98172a9ad Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/ee88158a-2677-4160-9b83-d2b98172a9ad Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace BinaryFormatter usage for Revit 2027 with .NET 10
Remove legacy customization icon assemblies for Revit 2027 / .NET 10
May 19, 2026
johnpierson
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revit 2027 moves Rhythm onto .NET 10, where the legacy resource loading path behind the shipped customization/icon DLLs throws at runtime. The most visible failure was
Batch.UpgradeFamilies, but the underlying issue affected any node path that loaded those assemblies.What changed
deploy/2027/RhythmCore.customization.dllanddeploy/2027/RhythmRevit.customization.dllRhythmCoreandRhythmRevitRhythmViewExtensionto skip downloading those DLLs for 2027 and delete stale local copies if presentRuntime behavior
BinaryFormatterfailure without changing node execution logicLegacy serialization cleanup
Documentation
Example of the packaging/build change:
And the runtime guard in the view extension: