Fix version, title, and description not applied during build#98
Merged
Conversation
Closed
…d sync AssemblyInfo.cs files Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/bfed52da-760f-4801-8c4c-40ef123c8acf Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix version in build.yml to include project details
Fix version, title, and description not applied during build
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.ymlpassed no version metadata to msbuild, andAssemblyInfo.csfiles had hardcoded, stale versions that were out of sync with the csproj formulas ($(RevitVersion).4.1for RhythmRevit,$(RevitVersion).1.1for RhythmCore). R27 was missing entirely from RhythmRevit's AssemblyInfo, and R26/R27 from RhythmCore's.Changes
build.yml: Added a version extraction step that reads the version suffix dynamically from each csproj. All 16msbuildinvocations now explicitly pass/p:Version,/p:AssemblyVersion,/p:FileVersion,/p:Title,/p:Description, and/p:Product:RhythmRevit/Properties/AssemblyInfo.cs: Replaced hardcoded"2025.7.1"with per-config#if/#elifchain covering R20–R27 (matching csproj formula). ConsolidatedAssemblyVersion,AssemblyFileVersion,AssemblyTitle,AssemblyProduct, andAssemblyDescriptioninto each block. Added missing R27 entry.RhythmCore/Properties/AssemblyInfo.cs: Same treatment — replaced hardcoded"2024.10.1"with R20–R27 blocks matching$(RevitVersion).1.1. Added missing R26 and R27 entries.