Skip to content

Fix version, title, and description not applied during build#98

Merged
johnpierson merged 2 commits into
masterfrom
copilot/fix-version-in-build-yml
May 19, 2026
Merged

Fix version, title, and description not applied during build#98
johnpierson merged 2 commits into
masterfrom
copilot/fix-version-in-build-yml

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

build.yml passed no version metadata to msbuild, and AssemblyInfo.cs files had hardcoded, stale versions that were out of sync with the csproj formulas ($(RevitVersion).4.1 for RhythmRevit, $(RevitVersion).1.1 for RhythmCore). R27 was missing entirely from RhythmRevit's AssemblyInfo, and R26/R27 from RhythmCore's.

Changes

  • build.yml: Added a version extraction step that reads the version suffix dynamically from each csproj. All 16 msbuild invocations now explicitly pass /p:Version, /p:AssemblyVersion, /p:FileVersion, /p:Title, /p:Description, and /p:Product:

    - name: Extract version information from project files
      run: |
        $revitVersionSuffix = ...  # parsed from "$(RevitVersion).4.1"
        echo "REVIT_VERSION_SUFFIX=$revitVersionSuffix" >> $env:GITHUB_ENV
    
    - name: Build RhythmRevit - Release R20
      run: |
        msbuild ... /p:Version="2020.$env:REVIT_VERSION_SUFFIX" \
                    /p:AssemblyVersion="2020.$env:REVIT_VERSION_SUFFIX" \
                    /p:Title="Rhythm for Dynamo|Revit2020" ...
  • RhythmRevit/Properties/AssemblyInfo.cs: Replaced hardcoded "2025.7.1" with per-config #if/#elif chain covering R20–R27 (matching csproj formula). Consolidated AssemblyVersion, AssemblyFileVersion, AssemblyTitle, AssemblyProduct, and AssemblyDescription into each block. Added missing R27 entry.

  • RhythmCore/Properties/AssemblyInfo.cs: Same treatment — replaced hardcoded "2024.10.1" with R20–R27 blocks matching $(RevitVersion).1.1. Added missing R26 and R27 entries.

Copilot AI linked an issue Apr 15, 2026 that may be closed by this pull request
…d sync AssemblyInfo.cs files

Agent-Logs-Url: https://github.com/johnpierson/RhythmForDynamo/sessions/bfed52da-760f-4801-8c4c-40ef123c8acf

Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix version in build.yml to include project details Fix version, title, and description not applied during build Apr 15, 2026
Copilot AI requested a review from johnpierson April 15, 2026 14:48
@johnpierson johnpierson marked this pull request as ready for review May 19, 2026 16:52
@johnpierson johnpierson merged commit 22931da into master May 19, 2026
1 check passed
@johnpierson johnpierson deleted the copilot/fix-version-in-build-yml branch May 19, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Version in Build.yml

2 participants