Control gpar of plot in strip

[LeonSaal]

Hi there,

here's the next question / request 😅

Is there a way to control the gpar for fills, edges, labels and quantities for each plot in a strip, as produced by venn(..., by= ...), seperately?
I'm mostly in terested in the quantities. I tried to pass a vector with the length of the combined quantities, hoping it would get split for the seperate plots, but only the first elements were reused for all plots.

Kind regards,
Leon

[jolars]

Hm, right, yes, I understand. Let me think about it. I'd like to support this but I'm not sure what the best API would be for it. Do you have any suggestion?

[LeonSaal]

Great! I think it would be best to be able to pass a named nested list for each parameter, with the groups produced with venn(... , by = ...) as the keys for more flexibility as well as the current way of recycling the parameters for each group.

For the named list, a .default-element would also make sense, that can be used for each group not specified in the named list.
The cases are:

# the default
plot(... , quantities = list()) 

# named list for certain groups
plot(... , quantities = list(group1 = list(col = ...)))

# named list with .default overriding the euler_options 
plot(... , quantities = list(group1 = list(col = ...), .default = list(col = ...)))

I think that should cover most of it

[jolars]

I see... but group1 could technically interfere with one of the other accepted argument names that quantities accept, right? One could also imagine:

plot(..., quantities = list(by_group = list(...)))

More verbose, but perhaps also more robust? Or maybe a top-level attribute is better:

plot(..., group_overrides = list(A = list(quantities = list(...))))

[LeonSaal]

I see your point and agree, that possible interference should be minimised. From your two suggestions I prefer the first one 🤔

[jolars]

In the end I did go with the former. Here's an example of how this API looks now:

f <- venn(fruits[, 1:4], by = list(sex))

plot(
  f,
  fills = list(
    by_group = list(
      male = list(fill = c("steelblue", "skyblue")),
      female = list(
        fill = c("tomato", "salmon", "firebrick", "white", "black", "purple")
      )
    )
  ),
  quantities = list(
    by_group = list(
      male = list(col = "white", fontsize = 14),
      female = list(col = "black", fontsize = 4)
    )
  ),
  labels = list(
    by_group = list(
      male = list(col = "navy"),
      female = list(col = "firebrick")
    )
  )
)