Skip Nmap on empty Masscan results; handle TCP/UDP-only scans; fix ping args#4
Open
jph4cks wants to merge 1 commit into
Open
Skip Nmap on empty Masscan results; handle TCP/UDP-only scans; fix ping args#4jph4cks wants to merge 1 commit into
jph4cks wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
masscanreturns no results for a target.nmapinvocation is correct for TCP-only, UDP-only, and mixed port discoveries.subprocessargument formatting forpingto avoid unexpected behavior.Description
main()to skipnmap_scanandnmap_vuln_scanwhenmasscan()returns an empty result for a target. (jpscan.py)nmap_scan()andnmap_vuln_scan()to usetarget_ports[ip].get('tcp', [])andget('udp', []), skip empty entries, and build protocol-specificnmapcommands for TCP-only, UDP-only, and mixed cases. (jpscan.py)get_mac()pingcall to pass-cand1as separate argv entries inPopen(Popen(["ping", "-c", "1", IP])). (jpscan.py)-pT:/-pU:forms when only one protocol is present. (jpscan.py)Testing
python3 -m py_compile jpscan.pywhich completed successfully. (passed)python3 jpscan.py -t 127.0.0.1 -p 1-10 -r 1000 -w 1in the CI environment wheremasscanis not installed, and the script handled the no-results path and skippednmapscans without crashing. (behavior verified)Codex Task