Resolve ambiguous CLI-agent file links via repo index + Files palette#2
Merged
Conversation
When a CLI agent (Claude Code, Codex, etc.) prints a bare filename or
shorthand path that doesn't resolve relative to its working directory,
fall back to the repo file index instead of producing no link:
- 0 matches -> no link
- 1 match -> linkify; click opens it directly
- 2+ matches -> linkify ("Open file…"); click opens the command-palette
Files mode pre-filled so the user disambiguates
Matching is exact-basename + ordered directory-component subsequence, so
`warp_features/lib.rs` resolves to `crates/warp_features/src/lib.rs`
(tolerating omitted intermediates like `crates/` and `src/`). The repo
index is snapshotted on the main thread (the background scan thread has
no AppContext) and indexed by basename per scan for O(1) candidate
lookup, keeping hover detection fast even with hundreds of candidates.
Gated by the existing CliAgentFileLinks flag + general.cli_agent_file_links
setting; no new flag. Adds a GridHighlightedLink::AmbiguousFile variant
and threads an optional pre-fill query through the OpenFilesPalette event.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve ambiguous CLI-agent file links via the repo index + Files palette.
When a CLI agent (Claude Code, Codex, etc.) prints a bare filename or shorthand path that doesn't resolve relative to its working directory, fall back to the repo file index instead of producing no link:
Matching is exact-basename + ordered directory-component subsequence, so
warp_features/lib.rsresolves tocrates/warp_features/src/lib.rs(tolerating omitted intermediates likecrates/andsrc/). The repo index is snapshotted on the main thread (the background scan thread has noAppContext) and indexed by basename per scan for O(1) candidate lookup, keeping hover detection fast even with hundreds of candidates.Changes
GridHighlightedLink::AmbiguousFilevariant and thread an optional pre-fill query through theOpenFilesPaletteeventCliAgentFileLinksflag +general.cli_agent_file_linkssetting — no new flagStacking