Skip to content

Comments

Fix commit id retrieval#206

Merged
jtec merged 4 commits intomainfrom
fix_commit_id_retrieval
Feb 4, 2026
Merged

Fix commit id retrieval#206
jtec merged 4 commits intomainfrom
fix_commit_id_retrieval

Conversation

@jtec
Copy link
Owner

@jtec jtec commented Feb 2, 2026

@jtec jtec requested a review from plutonheaven February 2, 2026 12:47
@plutonheaven
Copy link
Collaborator

plutonheaven commented Feb 2, 2026

@jtec I took the initiative to propose some additional changes to your PR.

Setting search_parent_directories=False in the call of git.Repo() was one of the change required.

I also added a function to get the commit ID from the installation of prx as a package, which writes info to a file named direct_url.json somewhere in the .venv folder (PEP 610).

I added a test in https://github.com/jtec/prx-import/pull/3, which seems to work!

@jtec
Copy link
Owner Author

jtec commented Feb 4, 2026

@plutonheaven Great! Should we merge this?

@jtec jtec merged commit d31b72c into main Feb 4, 2026
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants