Skip to content

ADP polish: cross-link sweep + post-merge Vercel preview audits #219

Description

@julianken

Follow-up to the agentic-design-patterns reference launch (PR #218 merged). Captures items deferred during the wave authoring + bot review.

Cross-link consistency pass

11 of 23 patterns ship with relatedSlugs: [] because the wave-authoring pass populated cross-links only for siblings that had already been authored at dispatch time, and the post-wave consistency pass was skipped. Per julianken-bot review: empirical impact is 32 one-way edges, zero symmetric pairs, 7 patterns with no incoming related links, and the parent-variant pair agentic-rag ↔ rag is asymmetric.

Patterns with empty arrays:

  • checkpointing, context-engineering, evaluation-llm-as-judge, guardrails, memory-management, multi-agent-debate, orchestrator-workers, planning, prompt-chaining, rag, routing

Plus tool-use-react has only one entry.

Each pattern should pick 2–4 obvious siblings (intra-layer + cross-layer where the pattern naturally pairs). Single PR; small editorial pass.

Stale guarantee comment

src/data/agentic-design-patterns/types.ts:73 says // 2-4 cross-link chips; build fails if any don't resolve. The build does not fail. No script in lint:adp validates relatedSlugs. Two fixes:

  1. Write the validator (add a lint-related-slugs.ts step to lint:adp that asserts each entry resolves AND that the array is non-empty — would have caught the issue above)
  2. OR fix the comment to say "non-empty entries must resolve to existing patterns; helpers.test.ts asserts at runtime" (no compile-time guarantee)

Recommendation: do (1) — turns the editorial requirement into a hard CI rule.

Vercel preview audits (PENDING-PREVIEW from Phase 1 #160 launch checklist)

After main deploys, validate against the Vercel preview:

  • Lighthouse mobile audit on hub + a few satellites (Reflexion, MCP, Agentic RAG). Targets: Perf ≥ 90, A11y ≥ 95, Best Practices ≥ 95, SEO ≥ 95
  • schema.org validator pass on hub + satellite URLs (https://validator.schema.org/)
  • OG image visual QA at 1200×630 (manually inspect 4–5 satellites)
  • Real-device mobile review (iPhone Safari + Pixel Chrome): hub scroll, satellite layout, sticky rail behavior, decision matrix mobile collapse

Open one follow-up sub-issue per Lighthouse miss; everything else is sign-off-only.

Custom OG fonts

next/og is currently using its system mono fallback (no custom JetBrains Mono bundled). The OG images render but type quality on social previews is mediocre. Add custom fonts via fonts: [{ data, name, style, weight }] array in the route. Reference: https://nextjs.org/docs/app/api-reference/file-conventions/metadata/opengraph-image#using-custom-fonts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions