[Audit log] Drift audit 2026-05-04 — deferred items

[julianken]

WHY

Drift audit 2026-05-04, per FINAL-PLAN.md § "Cold-start wontfix ceremony" (lines 396-408). Defers are logged here so day-one of the future nightly drift extractor (Epic E / #248) does not refile them.

This single issue replaces filing ~9 separate wontfix issues. Items annotated → tracked: <id> are listed for extractor-exclusion only — they are actively tracked elsewhere, not deferred.

WHAT (deferred-items checklist)

• nodes/02 finding 4 (SUGGESTION) — citation.ts hand-typed ReferenceInput shadow. src/lib/schema/citation.ts:21-29 shadows Post['references']; replace with NonNullable<Post['references']>[number]. Unblocks when git diff src/payload-types.ts | grep references shows new fields on the generated type.

• nodes/02 finding 6 (SUGGESTION) — SITE_CONFIG.name lowercase. src/lib/schema/config.ts:20 has siteName = 'detached-node' while UI capitalizes "Detached Node". Unblocks when I-6 (canonical brand decision) lands.

• nodes/03 (SUGGESTION) — docs/design-system-proposal.md. Decision needed: adopt phosphor palette into docs/design-system.md OR delete the proposal (the file is already deleted in chore(docs): purge docs/ to 4 files (delete 24) #240, so this checkbox is just the brand-decision TODO from I-5). Unblocks any user-facing color change.

• nodes/05 finding 3 (IMPORTANT) → tracked: I-23. budget-killswitch $50/mo cap; FINAL-PLAN line 314 routes to I-23 (sweep adds README note). Listed here for extractor-exclusion only.

• nodes/05 finding 4 (SUGGESTION) — eslint-disable directives without rationale. Unblocks when a react-hooks/exhaustive-deps audit runs, OR when surrounding code changes in src/components/FadeReveal.tsx or src/lib/hooks/use-gsap.ts.

• nodes/06 finding 4 (SUGGESTION) — block-console-log hook excludes incomplete. Unblocks when a new logger utility is added under src/lib/log* or an existing one is moved.

• nodes/06 finding 6 (SUGGESTION) — design-reviewer.md agent stack-blind. Unblocks when docs/design-system.md materially changes (after docs(scripts): purge Vercel-Blob refs from script docstrings #233's docs purge it'll be stable for a while).

• nodes/07 finding 5 (IMPORTANT) → tracked: #248f. 10 + 13 untested components; FINAL-PLAN line 326 routes to I-24f (Phase-3 quality gate). Listed here for extractor-exclusion only.

• nodes/07 finding 6 (SUGGESTION) — post-detail.spec.ts PR# comment cites Remove "Field Report" label from frontend (keep schema value) #133, actual was Remove post-type label from frontend (keep schema value) #134. Unblocks during any future edit to tests/e2e/public/post-detail.spec.ts lines 11-16.

• nodes/01 notes (SUGGESTION) — AUTHOR_CONFIG.sameAs URL unverified. https://github.com/detached-node likely a 404. Unblocks when I-6 (brand decision) lands; correlates with SITE_CONFIG.name.

DONE WHEN

Rolling audit log. Items move unchecked → checked when actioned in a follow-up PR; new defers append. Issue is never closed — register, not unit of work. At the next quarterly drift audit (or #248's first verdict-capable cycle), unchecked items are re-evaluated and either promoted or refreshed. → tracked: items are excluded from refile but stay listed for audit trail.

OUT OF SCOPE

• Actually fixing any listed item.
• Adding new defers not from this audit.

PRE-REQS

None.

[julianken-bot]

Review (julianken-bot)

Verification

• Read issue [Audit log] Drift audit 2026-05-04 — deferred items #249 body in full.
• Read .analysis/2026-05-04-drift-audit/REPORT.md (358 lines) and FINAL-PLAN.md § "Cold-start wontfix ceremony" (lines 396-408).
• Cross-checked each checkbox back to its nodes/*.json source to verify severity claims.
• Confirmed bot identity (/user.login = julianken-bot) and write collaborator permission.

Findings

1. IMPORTANT — severity mixing dilutes the register's purpose. Title and wontfix label frame this as a deferred-items register, but two checkboxes carry IMPORTANT-tier findings that FINAL-PLAN.md did NOT route to cold-start:

• nodes/05 finding 3 (budget-killswitch $50 cap) — plan line 314 maps it to I-23 (sweep adds README note), not deferral. Cold-start list (lines 400-406) excludes it.
• nodes/07 finding 5 (10+13 untested components) — plan line 326 maps it to I-24f under Epic E. The body says "tracked under [Epic] Drift detection v1: introduction-time + time-emergent #248's #248f child" but a wontfix label conflates "deferred" with "actively tracked elsewhere."

If a future extractor sees wontfix and skips refile, that's correct for SUGGESTIONs but wrong for IMPORTANTs with active tracking. Fix: either split (this register SUGGESTION-only; file two separate wontfix stubs linking to I-23 / #248f), or annotate inline → tracked: I-23 / → tracked: #248f and note in WHY that "tracked" items are listed for extractor-exclusion only.

2. IMPORTANT — "what would change my mind" triggers are mostly absent. Per the audit's spec, each item needs a reason AND an unblock trigger. Reasons are present; triggers are vague on 5 of 10:

• eslint-disable "until a focused react-hooks audit"
• block-console-log "until a hooks-tuning pass"
• design-reviewer.md "until next design-system pass"
• citation.ts "until a broader schema-typing pass"
• post-detail.spec.ts PR# "fix during the next test refactor"

Concrete triggers are testable; "next pass" is not. Recommend phrasing like "unblock when next PR touches src/lib/schema/" (citation.ts) or "unblock when I-6 lands" (SITE_CONFIG, since brand spelling is decided there). Brand items already have decent triggers — keep that pattern.

3. SUGGESTION — nodes/03 design-system-proposal item is over-explained. That bullet says the file itself is deleted in #240 and "this checkbox is here in case Julian wants to author a brand-decision doc." Proposal is gone; "in case Julian wants" creates an entry with no end-state. Drop it, or rewrite WHY as "tracking the brand-decision doc TODO referenced in I-5."

Praise (specific)

The "never closed — it's a register, not a unit of work" line in DONE WHEN is the language an auto-close bot needs to read; pairing with wontfix (which most close-stale automation special-cases) is structurally correct. Anchoring each bullet to FINAL-PLAN.md lines + nodes/NN.json finding numbers makes future diffability clean — the next quarterly audit can mechanically join this register against new node outputs.

---

Verdict: NEEDS-REVISION.

[julianken]

Revised cycle-2:

• Severity-mixing (IMPORTANT-1): annotated the two IMPORTANT-tier items inline with → tracked: I-23 (budget-killswitch) and → tracked: #248f (untested components) instead of deleting. Preserves the audit trail and keeps the FINAL-PLAN cross-references discoverable. Added a sentence in WHY clarifying that → tracked: items are listed for extractor-exclusion only, not deferral. DONE WHEN reiterates the same.
• Vague unblock triggers (IMPORTANT-2): all 5 vague items now have file-path-anchored conditions:
  • citation.ts → git diff src/payload-types.ts | grep references
  • eslint-disables → react-hooks audit OR change to src/components/FadeReveal.tsx / src/lib/hooks/use-gsap.ts
  • block-console-log → new logger under src/lib/log* (or existing moved)
  • design-reviewer → material change to docs/design-system.md
  • post-detail.spec.ts → any edit to lines 11-16 of that file
• Design-system-proposal over-explained (SUGGESTION): tightened to the decision/end-state framing — "adopt into design-system.md OR delete proposal," unblocks on any user-facing color change. Removed the "in case Julian wants" hedge.

Body is 434 words (under the 500 cap).

[julianken-bot]

Review (julianken-bot, cycle-2)

Verification

• Read revised issue body in full (current version, post your 20:58 comment).
• Cross-referenced each cycle-1 finding against the new text.
• Word count: body is ~430 words, under cap.

Cycle-1 findings — resolution check

IMPORTANT-1 (severity-mixing) — RESOLVED. Inline → tracked: I-23 on the budget-killswitch bullet and → tracked: #248f on the untested-components bullet preserve the audit trail. WHY paragraph 2 ("extractor-exclusion only — they are actively tracked elsewhere, not deferred") and DONE WHEN final sentence both reinforce the distinction. A future extractor matching on → tracked: can mechanically skip these without losing the cross-reference.

IMPORTANT-2 (vague triggers) — RESOLVED. All five previously-vague items now name a concrete file path or testable condition:

• citation.ts → git diff src/payload-types.ts | grep references
• eslint-disable → change to src/components/FadeReveal.tsx or src/lib/hooks/use-gsap.ts
• block-console-log → new file under src/lib/log*
• design-reviewer.md → material change to docs/design-system.md
• post-detail.spec.ts → edit to lines 11-16

The two pre-existing well-anchored items (SITE_CONFIG, AUTHOR_CONFIG.sameAs keyed on I-6) keep their pattern.

SUGGESTION-3 (design-system-proposal over-explained) — RESOLVED. Now reads as a binary decision (adopt phosphor palette into docs/design-system.md OR delete the proposal) with a concrete unblock condition (any user-facing color change). The "in case Julian wants" hedge is gone.

Second-pass scan (R8)

Looked for new issues introduced by the revision. Nothing rises above noise. The "10 + 13 untested components" phrasing on the #248f bullet is a verbatim citation from the source node; awkward but faithful. The DONE WHEN section's two reiterations of the extractor-exclusion rule (WHY + DONE WHEN) is mild redundancy but defensive — auto-extractors may parse one section and not the other.

Praise (specific)

The decision to annotate-rather-than-split (keeping I-23 / #248f items inline with → tracked:) is the right call: splitting would have created three issues for one audit, and the audit-trail value of seeing all defers in one register outweighs the extractor-correctness gain. The doubled clarification (WHY + DONE WHEN) is the structural cost of that decision, paid willingly.

---

Verdict: APPROVED.