From d893c147d5bced75fec1a5515db21d513d10f66f Mon Sep 17 00:00:00 2001 From: Benny Zlotnik Date: Wed, 31 Dec 2025 09:44:24 +0200 Subject: [PATCH] ridesx: improve error for ridesx flashing Signed-off-by: Benny Zlotnik --- packages/jumpstarter-driver-ridesx/README.md | 4 ++-- .../jumpstarter_driver_ridesx/client.py | 14 +++++++++----- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/jumpstarter-driver-ridesx/README.md b/packages/jumpstarter-driver-ridesx/README.md index df55dfc37..cbb034dfb 100644 --- a/packages/jumpstarter-driver-ridesx/README.md +++ b/packages/jumpstarter-driver-ridesx/README.md @@ -104,7 +104,7 @@ Both drivers require: ```{testcode} # Flash a single partition -ridesx_client.flash("/path/to/boot.img", partition="boot") +ridesx_client.flash("/path/to/boot.img", target="boot") ``` ### Flash Multiple Partitions @@ -125,7 +125,7 @@ The driver automatically handles compressed images (`.gz`, `.gzip`, `.xz`): ```{testcode} # Flash compressed images - decompression is automatic -ridesx_client.flash("/path/to/boot.img.gz", partition="boot") +ridesx_client.flash("/path/to/boot.img.gz", target="boot") ``` ### Power Control diff --git a/packages/jumpstarter-driver-ridesx/jumpstarter_driver_ridesx/client.py b/packages/jumpstarter-driver-ridesx/jumpstarter_driver_ridesx/client.py index c40a996d8..2a557eeca 100644 --- a/packages/jumpstarter-driver-ridesx/jumpstarter_driver_ridesx/client.py +++ b/packages/jumpstarter-driver-ridesx/jumpstarter_driver_ridesx/client.py @@ -81,7 +81,7 @@ def flash( self, path: str | Dict[str, str], *, - partition: str | None = None, + target: str | None = None, operator: Operator | Dict[str, Operator] | None = None, compression=None, ): @@ -89,10 +89,14 @@ def flash( partitions = path operators = operator if isinstance(operator, dict) else None else: - if partition is None: - raise ValueError("'partition' must be provided") - partitions = {partition: path} - operators = {partition: operator} if isinstance(operator, Operator) else None + if target is None: + raise ValueError( + "This driver requires a target partition.\n" + "Usage: j storage flash --target :\n" + "Example: j storage flash -t boot_a:aboot.img -t system_a:rootfs.simg -t system_b:qm_var.simg" + ) + partitions = {target: path} + operators = {target: operator} if isinstance(operator, Operator) else None for partition_name, file_path in partitions.items(): if not file_path or not file_path.strip():