From 6f3210492c1540a558f29b7fe452432db9c9d7aa Mon Sep 17 00:00:00 2001 From: Frederic COLLONVAL Date: Mon, 19 Apr 2021 09:12:56 +0200 Subject: [PATCH 1/2] Support legacy notebook launcher --- jupyterlab_pullrequests/__init__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/jupyterlab_pullrequests/__init__.py b/jupyterlab_pullrequests/__init__.py index f53bed2..dfe0946 100644 --- a/jupyterlab_pullrequests/__init__.py +++ b/jupyterlab_pullrequests/__init__.py @@ -19,6 +19,12 @@ def _load_jupyter_server_extension(server_app): from .base import PRConfig from .handlers import setup_handlers + log = server_app.log config = PRConfig(config=server_app.config) - setup_handlers(server_app.web_app, config) + setup_handlers(server_app, config) server_app.log.info("Registered jupyterlab_pullrequests extension") + + +# for legacy launching with notebok (e.g. Binder) +_jupyter_server_extension_paths = _jupyter_server_extension_points +load_jupyter_server_extension = _load_jupyter_server_extension From 75badfcf9d21ba8deff321b1b489bac433537d8f Mon Sep 17 00:00:00 2001 From: Nicholas Bollweg Date: Mon, 19 Apr 2021 20:08:40 -0400 Subject: [PATCH 2/2] revert extra changes from #44 --- jupyterlab_pullrequests/__init__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/jupyterlab_pullrequests/__init__.py b/jupyterlab_pullrequests/__init__.py index dfe0946..ffe3ee5 100644 --- a/jupyterlab_pullrequests/__init__.py +++ b/jupyterlab_pullrequests/__init__.py @@ -19,9 +19,8 @@ def _load_jupyter_server_extension(server_app): from .base import PRConfig from .handlers import setup_handlers - log = server_app.log config = PRConfig(config=server_app.config) - setup_handlers(server_app, config) + setup_handlers(server_app.web_app, config) server_app.log.info("Registered jupyterlab_pullrequests extension")