From 4a5730c5245b3085a857993f23be8558591d215d Mon Sep 17 00:00:00 2001
From: Jesse Stuart <email@jessestuart.ca>
Date: Thu, 9 Apr 2026 11:45:24 -0400
Subject: [PATCH 1/2] fix: don't generate empty ALTER TABLE when nothing
 changed

---
 src/diff.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/diff.rs b/src/diff.rs
index 86a6981..300058f 100644
--- a/src/diff.rs
+++ b/src/diff.rs
@@ -342,7 +342,7 @@ fn compare_create_table(a: &CreateTable, b: &CreateTable) -> Option<Vec<Statemen
     let a_column_names: HashSet<_> = a.columns.iter().map(|c| c.name.clone()).collect();
     let b_column_names: HashSet<_> = b.columns.iter().map(|c| c.name.clone()).collect();
 
-    let ops = a
+    let operations: Vec<_> = a
         .columns
         .iter()
         .filter_map(|ac| {
@@ -373,11 +373,15 @@ fn compare_create_table(a: &CreateTable, b: &CreateTable) -> Option<Vec<Statemen
         }))
         .collect();
 
+    if operations.is_empty() {
+        return None;
+    }
+
     Some(vec![Statement::AlterTable {
         name: a.name.clone(),
         if_exists: a.if_not_exists,
         only: false,
-        operations: ops,
+        operations,
         location: None,
         on_cluster: a.on_cluster.clone(),
         iceberg: false,

From 0170ab7839bd757624133e71678404033c041e42 Mon Sep 17 00:00:00 2001
From: Jesse Stuart <email@jessestuart.ca>
Date: Thu, 9 Apr 2026 11:36:16 -0400
Subject: [PATCH 2/2] fix: column names are equal regardless of quote style

---
 src/diff.rs      |  8 ++++----
 src/lib.rs       | 36 ++++++++++++++++++++++++++++++------
 src/migration.rs |  2 +-
 3 files changed, 35 insertions(+), 11 deletions(-)

diff --git a/src/diff.rs b/src/diff.rs
index 300058f..7a5a66a 100644
--- a/src/diff.rs
+++ b/src/diff.rs
@@ -339,14 +339,14 @@ fn compare_create_table(a: &CreateTable, b: &CreateTable) -> Option<Vec<Statemen
         return None;
     }
 
-    let a_column_names: HashSet<_> = a.columns.iter().map(|c| c.name.clone()).collect();
-    let b_column_names: HashSet<_> = b.columns.iter().map(|c| c.name.clone()).collect();
+    let a_column_names: HashSet<_> = a.columns.iter().map(|c| c.name.value.clone()).collect();
+    let b_column_names: HashSet<_> = b.columns.iter().map(|c| c.name.value.clone()).collect();
 
     let operations: Vec<_> = a
         .columns
         .iter()
         .filter_map(|ac| {
-            if b_column_names.contains(&ac.name) {
+            if b_column_names.contains(&ac.name.value) {
                 None
             } else {
                 // drop column if it only exists in `a`
@@ -359,7 +359,7 @@ fn compare_create_table(a: &CreateTable, b: &CreateTable) -> Option<Vec<Statemen
             }
         })
         .chain(b.columns.iter().filter_map(|bc| {
-            if a_column_names.contains(&bc.name) {
+            if a_column_names.contains(&bc.name.value) {
                 None
             } else {
                 // add the column if it only exists in `b`
diff --git a/src/lib.rs b/src/lib.rs
index 5643f85..b3a40b8 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -173,17 +173,41 @@ mod tests {
     #[test]
     fn diff_create_table() {
         run_test_cases(
-            vec![TestCase {
-                dialect: Dialect::Generic,
-                sql_a: "CREATE TABLE foo(\
+            vec![
+                TestCase {
+                    dialect: Dialect::Generic,
+                    sql_a: "CREATE TABLE foo(\
                             id int PRIMARY KEY
                         )",
-                sql_b: "CREATE TABLE foo(\
+                    sql_b: "CREATE TABLE foo(\
                             id int PRIMARY KEY
                         );\
                         CREATE TABLE bar (id INT PRIMARY KEY);",
-                expect: "CREATE TABLE bar (id INT PRIMARY KEY);",
-            }],
+                    expect: "CREATE TABLE bar (id INT PRIMARY KEY);",
+                },
+                TestCase {
+                    dialect: Dialect::Generic,
+                    sql_a: "CREATE TABLE foo(\
+                            id int PRIMARY KEY
+                        )",
+                    sql_b: "CREATE TABLE foo(\
+                            \"id\" int PRIMARY KEY
+                        );\
+                        CREATE TABLE bar (id INT PRIMARY KEY);",
+                    expect: "CREATE TABLE bar (id INT PRIMARY KEY);",
+                },
+                TestCase {
+                    dialect: Dialect::Generic,
+                    sql_a: "CREATE TABLE foo(\
+                            \"id\" int PRIMARY KEY
+                        )",
+                    sql_b: "CREATE TABLE foo(\
+                            id int PRIMARY KEY
+                        );\
+                        CREATE TABLE bar (id INT PRIMARY KEY);",
+                    expect: "CREATE TABLE bar (id INT PRIMARY KEY);",
+                },
+            ],
             |ast_a, ast_b| ast_a.diff(&ast_b),
         );
     }
diff --git a/src/migration.rs b/src/migration.rs
index b83acae..90a1a82 100644
--- a/src/migration.rs
+++ b/src/migration.rs
@@ -265,7 +265,7 @@ fn migrate_alter_table(
                 t.columns.push(column_def.clone());
             }
             AlterTableOperation::DropColumn { column_name, .. } => {
-                t.columns.retain(|c| c.name != *column_name);
+                t.columns.retain(|c| c.name.value != *column_name.value);
             }
             AlterTableOperation::AlterColumn { column_name, op } => {
                 t.columns.iter_mut().for_each(|c| {