Deprecate Space#moveWindows in macOS 13.6+, 14.5+ and 15.0+ (#354)

Author: kasper

CHANGELOG.md

@@ -10,6 +10,7 @@ Release: dd.mm.yyyy
 
 - **Breaking:** Phoenix now requires macOS Big Sur (11) or higher (required by Xcode 16).
 - **Breaking:** Function `App#launch(...)` is now asynchronous and the function does not return the app. Pass a callback function as the third argument to receive the app after launching.
+- **Breaking:** Moving windows between spaces is not anymore supported if you have macOS 13.6+, 14.5+ or 15.0+ ([#354](https://github.com/kasper/phoenix/issues/354)).
 - Upgrade Sparkle to 2.7.1.
 - Xcode 16 is now required for building.
 
@@ -19,6 +20,10 @@ Release: dd.mm.yyyy
 
 - Change: Function `launch(...)` is now asynchronous and the function does not return the app. Pass a callback function as the third argument to receive the app after launching.
 
+### Space
+
+- Deprecation: Function `Space#moveWindows` is not anymore supported if you have macOS 13.6+, 14.5+ or 15.0+. Apple has restricted the access for 3rd party apps to call the relevant APIs ([#354](https://github.com/kasper/phoenix/issues/354)).
+
 4.0.1
 -----
 

Phoenix/NSProcessInfo+PHExtension.h

@@ -10,6 +10,8 @@
 
 + (BOOL)isOperatingSystemAtLeastBigSur;
 + (BOOL)isOperatingSystemAtLeastMonterey;
++ (BOOL)isOperatingSystemAtLeastVentura136;
 + (BOOL)isOperatingSystemAtLeastSonoma145;
++ (BOOL)isOperatingSystemAtLeastSequoia;
 
 @end

Phoenix/NSProcessInfo+PHExtension.m

@@ -18,9 +18,19 @@ + (BOOL)isOperatingSystemAtLeastMonterey {
     return [[self processInfo] isOperatingSystemAtLeastVersion:monterey];
 }
 
++ (BOOL)isOperatingSystemAtLeastVentura136 {
+    NSOperatingSystemVersion ventura136 = {.majorVersion = 13, .minorVersion = 6, .patchVersion = 0};
+    return [[self processInfo] isOperatingSystemAtLeastVersion:ventura136];
+}
+
 + (BOOL)isOperatingSystemAtLeastSonoma145 {
     NSOperatingSystemVersion sonoma145 = {.majorVersion = 14, .minorVersion = 5, .patchVersion = 0};
     return [[self processInfo] isOperatingSystemAtLeastVersion:sonoma145];
 }
 
++ (BOOL)isOperatingSystemAtLeastSequoia {
+    NSOperatingSystemVersion sequoia = {.majorVersion = 15, .minorVersion = 0, .patchVersion = 0};
+    return [[self processInfo] isOperatingSystemAtLeastVersion:sequoia];
+}
+
 @end

Phoenix/PHSpace.m

@@ -15,7 +15,6 @@
 typedef NSUInteger CGSConnectionID;
 typedef NSUInteger CGSSpaceID;
 typedef NSUInteger CGSWorkspaceID;
-typedef NSUInteger CGSMoveWindowCompatID;
 
 typedef enum {
     kCGSSpaceIncludesCurrent = 1 << 0,
@@ -38,10 +37,6 @@ @implementation PHSpace
 static NSString *const CGSSpaceIDKey = @"ManagedSpaceID";
 static NSString *const CGSSpacesKey = @"Spaces";
 
-// An arbitrary ID we can use with CGSSpaceSetCompatID
-static const CGSMoveWindowCompatID PHMoveWindowsCompatId = 4000;
-static const CGSMoveWindowCompatID PHMoveWindowsResetCompatId = 0;
-
 // XXX: Undocumented private API to get the CGSConnectionID for the default connection for this process
 CGSConnectionID CGSMainConnectionID(void);
 
@@ -70,15 +65,6 @@ @implementation PHSpace
 // only works prior to macOS 14.5
 void CGSMoveWindowsToManagedSpace(CGSConnectionID connection, CFArrayRef windowIds, CGSSpaceID spaceId);
 
-// XXX: Undocumented private API to set a space’s (legacy) compatId
-CGError CGSSpaceSetCompatID(CGSConnectionID connection, CGSSpaceID spaceId, CGSMoveWindowCompatID compatId);
-
-// XXX: Undocumented private API to move the given windows (CGWindowIDs) to the given space by its (legacy) compatId
-CGError CGSSetWindowListWorkspace(CGSConnectionID connection,
-                                  CGWindowID windowIds[],
-                                  NSUInteger windowCount,
-                                  CGSMoveWindowCompatID compatId);
-
 #pragma mark - Initialising
 
 - (instancetype)initWithIdentifier:(NSUInteger)identifier {
@@ -238,34 +224,16 @@ - (void)removeWindows:(NSArray<PHWindow *> *)windows {
                                (__bridge CFArrayRef) @[@(self.identifier)]);
 }
 
-/* Fixes https://github.com/kasper/phoenix/issues/348, referencing:
- * - https://github.com/koekeishiya/yabai/issues/2240#issuecomment-2116326165
- * - https://github.com/ianyh/Amethyst/issues/1643#issuecomment-2132519682
- */
-- (void)moveWindowsWithCompatId:(NSArray<PHWindow *> *)windows {
-    NSArray<NSNumber *> *windowIds = [self identifiersForWindows:windows];
-    NSUInteger windowCount = [windowIds count];
-    NSMutableData *windowIdSequence = [[NSMutableData alloc] initWithCapacity:windowCount * sizeof(CGWindowID)];
-    for (NSNumber *windowId in windowIds) {
-        CGWindowID value = windowId.unsignedIntValue;
-        [windowIdSequence appendBytes:&value length:sizeof(CGWindowID)];
-    }
-
-    CGSConnectionID connection = CGSMainConnectionID();
-    CGSSpaceSetCompatID(connection, self.identifier, PHMoveWindowsCompatId);
-    CGSSetWindowListWorkspace(connection, (CGWindowID *)[windowIdSequence bytes], windowCount, PHMoveWindowsCompatId);
-    CGSSpaceSetCompatID(connection, self.identifier, PHMoveWindowsResetCompatId);
-}
-
 - (void)moveWindows:(NSArray<PHWindow *> *)windows {
-    if (![NSProcessInfo isOperatingSystemAtLeastSonoma145]) {
-        CGSMoveWindowsToManagedSpace(
-            CGSMainConnectionID(), (__bridge CFArrayRef)[self identifiersForWindows:windows], self.identifier);
+    // Moving windows is not anymore supported in macOS 13.6+, 14.5+ and 15.0+
+    if ([NSProcessInfo isOperatingSystemAtLeastVentura136] || [NSProcessInfo isOperatingSystemAtLeastSonoma145] ||
+        [NSProcessInfo isOperatingSystemAtLeastSequoia]) {
+        NSLog(@"Deprecated: Function Space#moveWindows(...) is deprecated and will be removed in later versions.");
         return;
     }
 
-    // CGSMoveWindowsToManagedSpace is broken in macOS 14.5+, so use the legacy Compat ID API instead
-    [self moveWindowsWithCompatId:windows];
+    CGSMoveWindowsToManagedSpace(
+        CGSMainConnectionID(), (__bridge CFArrayRef)[self identifiersForWindows:windows], self.identifier);
 }
 
 @end

docs/docs/api/space.md

@@ -6,6 +6,10 @@ Use the Space to control spaces. *These features are only supported on El Capita
 You can switch to a space by focusing on a window in that space. By default, macOS also supports the keyboard shortcut <kbd>Control</kbd> + <kbd>←/→</kbd> to navigate between spaces.
 :::
 
+:::warning Moving Windows Between Spaces
+Moving windows between spaces is not anymore supported if you have macOS 13.6+, 14.5+ or 15.0+. Apple has restricted the access for 3rd party apps to call the relevant APIs.
+:::
+
 ## Interface
 
 ```javascript
@@ -41,7 +45,7 @@ end
 
 ### 3.0.0+
 
-- `moveWindows(Array<Window> windows)` moves the given windows to the space (macOS 10.13+)
+- `moveWindows(Array<Window> windows)` moves the given windows to the space (macOS 10.13+, <13.6, <14.5, <15.0)
 
 ### Optionals