-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Labels
kind/feature-requesttriage/acceptedIssues which should be fixed (post-triage)Issues which should be fixed (post-triage)
Description
From knative/eventing-contrib#297
Right now SecretToken appears to be required:
https://github.com/knative/eventing-sources/blob/master/pkg/apis/sources/v1alpha1/githubsource_types.go#L66
I think it would be nice if it were made optional, and if not provided then the system just created something to use (like a UUID). This value has no meaning outside of this subscription so I don't need the requirement to force the user to specify it. However, if someone does want to do so they can.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/feature-requesttriage/acceptedIssues which should be fixed (post-triage)Issues which should be fixed (post-triage)