From a827deffd6a9ecd51b718295c588c2f194543c8b Mon Sep 17 00:00:00 2001 From: Ankitsinghsisodya Date: Wed, 1 Apr 2026 15:52:59 +0530 Subject: [PATCH] hack: quote YAML_OUTPUT_DIR variable in rm command Without quotes, a path containing spaces causes incorrect glob expansion and may silently delete the wrong files or fail unexpectedly. --- hack/generate-yamls.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/generate-yamls.sh b/hack/generate-yamls.sh index b1ace4e6cba..bb6b896bf29 100755 --- a/hack/generate-yamls.sh +++ b/hack/generate-yamls.sh @@ -45,7 +45,7 @@ readonly YAML_LIST_FILE=${2:?"Second argument must be the output file"} if [[ -z "${YAML_OUTPUT_DIR:-}" ]]; then readonly YAML_OUTPUT_DIR="$(mktemp -d)" fi -rm -fr ${YAML_OUTPUT_DIR}/*.yaml +rm -fr "${YAML_OUTPUT_DIR}"/*.yaml # Generated Knative component YAML files readonly EVENTING_CORE_YAML=${YAML_OUTPUT_DIR}/"eventing-core.yaml"