From 69f09d1a206a900ee0a11735bac96027ef259297 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Tue, 5 May 2026 18:30:26 +0700 Subject: [PATCH 1/2] fix: replace assert to if-return. Less probability to get troubles in the future --- src/spork.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/spork.cpp b/src/spork.cpp index 659dc7e8946c..0a4826b53d44 100644 --- a/src/spork.cpp +++ b/src/spork.cpp @@ -144,7 +144,9 @@ bool CSporkManager::ProcessSpork(const CSporkMessage& spork) uint256 hash = spork.GetHash(); std::string strLogMsg{strprintf("SPORK -- hash: %s id: %d value: %10d", hash.ToString(), spork.nSporkID, spork.nValue)}; - assert(spork.GetSignerKeyID().has_value()); + + if (spork.GetSignerKeyID().has_value()) return false; + auto keyIDSigner = spork.GetSignerKeyID().value(); { From 182a8d67bff86a8d4eb3f050f108c67f3b94dd7e Mon Sep 17 00:00:00 2001 From: PastaClaw Date: Tue, 5 May 2026 06:48:35 -0500 Subject: [PATCH 2/2] fix: correct spork signer guard --- src/spork.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spork.cpp b/src/spork.cpp index 0a4826b53d44..7ca815bcf6e4 100644 --- a/src/spork.cpp +++ b/src/spork.cpp @@ -145,7 +145,7 @@ bool CSporkManager::ProcessSpork(const CSporkMessage& spork) std::string strLogMsg{strprintf("SPORK -- hash: %s id: %d value: %10d", hash.ToString(), spork.nSporkID, spork.nValue)}; - if (spork.GetSignerKeyID().has_value()) return false; + if (!spork.GetSignerKeyID().has_value()) return false; auto keyIDSigner = spork.GetSignerKeyID().value();