Skip to content

add function_variables key in JSON validation#73

Merged
dinogun merged 1 commit into
kruize:mainfrom
khansaad:update_search_space
Jul 13, 2022
Merged

add function_variables key in JSON validation#73
dinogun merged 1 commit into
kruize:mainfrom
khansaad:update_search_space

Conversation

@khansaad
Copy link
Copy Markdown
Contributor

@khansaad khansaad commented Jul 5, 2022

Signed-off-by: Saad Khan saakhan@redhat.com

This PR adds the function_variables key back in the search space JSON which was failing the validation process.
The function_variables key was removed earlier as part of the feature enhancement under issue #30 where we have planned to separate this and the objective function in a different API.

Signed-off-by: Saad Khan <saakhan@redhat.com>
@khansaad khansaad self-assigned this Jul 5, 2022
@khansaad khansaad requested review from chandrams and dinogun July 5, 2022 07:09
Copy link
Copy Markdown
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 25820f1 into kruize:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants