[LFX Term 1 2026] Restoring LLM Edge Benchmark Suite Single Task Bench#408
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an LLM edge benchmark suite, adding a requirements file and implementing a base model class. The predict method was refactored to use streaming for measuring prefill latency, and dummy preprocess, postprocess, and train methods were added to satisfy pipeline requirements. A review comment suggests that the train method should return the model path from an instance variable rather than kwargs, as the latter may be empty during execution, leading to an incorrect return value.
|
@MooreZheng sir, I have added Readme for LLM Edge Benchmark Suite Single Task Bench, a Requirements.txt and minimal changes in the Basemodel.py to make it work, Screencast.from.2026-04-23.18-52-16.webm |
|
MooreZheng
left a comment
There was a problem hiding this comment.
- try to make the preprocess optionable to save future burden
- check whether there is problem for the prediction fuction. If not, just leave it there.
4064b41 to
05c26e9
Compare
|
@MooreZheng Sir, Have looked into both questions — here's where things stand:
Two minor items I left as-is for now: |
Screencast.from.2026-05-20.16-35-27.webmThe example runs without the pre-process function !! |
MooreZheng
left a comment
There was a problem hiding this comment.
Good! Very close to the final version. Just squash the commit into one and this PR is good to go.
15a80af to
5170821
Compare
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
5170821 to
6f94471
Compare
|
@MooreZheng Sir @hsj576 Sir squashed the commits !! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hsj576, MooreZheng, NishantSinghhhhh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
This PR restores and fixes the
llm-edge-benchmark-suite(single_task_bench) so it successfully executes end-to-end within the current IanvsSingleTaskLearningparadigm.Previously, the LLM benchmarking pipeline was failing due to missing dependencies, pipeline contract mismatches (missing/strict method signatures), and inaccurate C++ stderr log parsing for latency metrics.
Key changes include:
requirements.txtto explicitly includellama-cpp-pythonand other necessary inference packages.preprocessandpostprocessmethods toLlamaCppModelwith optional arguments (data=None,**kwargs) to satisfy the strict signature checks of the Ianvs pipeline without throwingTypeError.