feat: allow forcing cache control header#2
Open
albaad wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @albaad, Could you add an explanation of what this PR resolve in the description? |
b7b3c7f to
2838022
Compare
2838022 to
d872b4f
Compare
Author
|
Hi @landrade, I’ve updated the PR description with an explanation of what it resolves—sorry for the long delay! Let me know if you need anything else. |
|
Hi @landrade, Just checking if there’s anything missing or something I can do to help move this forward. Happy to address any feedback or make further changes if needed. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max-ageand scope.cache.ContextWithForceCacheControl(ctx, true)that marks a request as eligible for Cache-Control header emission even when errors are present. The middleware uses this signal to compute and write the header from existing cache hints.