Skip to content

fix(ui): prevent LazyVStack layout hang with 700+ cards #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergioestebance wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): prevent LazyVStack layout hang with 700+ cards #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Sources/KanbanCode/ChannelShareController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,20 +230,19 @@ final class ChannelShareController {
}

private static func drainStderr(_ handle: FileHandle, tag: String) {
Task.detached {
DispatchQueue.global(qos: .utility).async {
while true {
let data = handle.availableData
if data.isEmpty { return }
if let s = String(data: data, encoding: .utf8) {
// Keep share-related diagnostics quiet unless debugging.
FileHandle.standardError.write(Data("\(tag) \(s)".utf8))
}
}
}
}

private static func drainStdout(_ handle: FileHandle, tag: String) {
Task.detached {
DispatchQueue.global(qos: .utility).async {
while true {
let data = handle.availableData
if data.isEmpty { return }
Expand Down
4 changes: 2 additions & 2 deletions Sources/KanbanCode/ListBoardView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ struct ListBoardView: View {

private func scrollView(proxy: ScrollViewProxy) -> some View {
ScrollView {
LazyVStack(alignment: .leading, spacing: 0, pinnedViews: [.sectionHeaders]) {
LazyVStack(alignment: .leading, spacing: 0) {
channelsSection
ForEach(sections, id: \.column) { section in
sectionView(for: section)
Expand Down Expand Up @@ -350,7 +350,7 @@ private struct ListBoardSectionView: View {
onReorderCard: onReorderCard
))
} else {
LazyVStack(spacing: 4) {
VStack(spacing: 4) {
ForEach(section.cards) { card in
if dragState.reorderTargetId == card.id && dragState.reorderAbove {
ReorderIndicator()
Expand Down