fix(install): add api.github.com fallback for version detection in install.sh#110
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.sh的get_latest_version()函数仅依赖github.com/releases/latest的 HTTP 重定向来获取版本号。当该域名不可达时(常见于国内网络环境),安装脚本会直接报错退出,而install.ps1已有api.github.com的 fallback 机制。Changes
get_latest_version()添加 fallback:当github.com/releases/latest不可达时,自动通过api.github.com/repos/${REPO}/releases/latestAPI 获取tag_nameUser-Agentheader 以避免被限流Test
在
github.com连接超时的网络环境下验证:v0.5.0