fix(install): convert OSArchitecture enum to string before switch comparison#111
Merged
Merged
Conversation
…parison PowerShell 5.1 returns Architecture enum instead of string for System.Runtime.InteropServices.RuntimeInformation.OSArchitecture, causing switch comparison to fail with 'Unsupported architecture' error.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
install.ps1failing with[ERROR] Unsupported architectureon Windows PowerShell 5.1.Root Cause
In PowerShell 5.1,
System.Runtime.InteropServices.RuntimeInformation.OSArchitecturereturns aSystem.Runtime.InteropServices.Architectureenum value (e.g.X64), not a string. When theswitchstatement compared the enum directly against string literals"X64"and"Arm64", the comparison failed silently, falling through to thedefaultbranch which throws the error.Fix
Convert the enum to string via
.ToString()before theswitchcomparison:Verification
powershell -File install.ps1 -SkipPathUpdate -Version "v0.5.0"— installed successfully