Skip to content

Commit 13a19f7

Browse files
committed
feat: remove deprecated apis
1 parent 1b7c4ff commit 13a19f7

9 files changed

Lines changed: 10 additions & 74 deletions

File tree

leancloud/engine/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import sys
44
import json
5-
import warnings
65

76
from werkzeug.wrappers import Request
87
from werkzeug.wrappers import Response
@@ -71,11 +70,6 @@ def __call__(self, environ, start_response):
7170
return self.cloud_app(environ, start_response)
7271
return self.origin_app(environ, start_response)
7372

74-
@property
75-
def current_user(self):
76-
warnings.warn('Engine.current_user is deprecated, please use Engine.current.user instead', leancloud.LeanCloudWarning)
77-
return user
78-
7973
def wrap(self, wsgi_app):
8074
if leanengine.root_engine:
8175
raise RuntimeError("It's forbidden that overwriting wsgi_func.")

leancloud/engine/cloudfunc.py

Lines changed: 0 additions & 16 deletions
This file was deleted.

leancloud/file_.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import hashlib
1111
import uuid
1212
import logging
13-
import warnings
1413
import threading
1514

1615
import requests
@@ -33,7 +32,7 @@
3332
class File(object):
3433
_class_name = '_File' # walks like a leancloud.Object
3534

36-
def __init__(self, name='', data=None, mime_type=None, type_=None):
35+
def __init__(self, name='', data=None, mime_type=None):
3736
self._name = name
3837
self.id = None
3938
self._url = None
@@ -45,10 +44,6 @@ def __init__(self, name='', data=None, mime_type=None, type_=None):
4544
if self.current_user and self.current_user != None: # NOQA: self.current_user may be a thread_local object
4645
self._metadata['owner'] = self.current_user.id
4746

48-
if type_ is not None:
49-
warnings.warn(LeanCloudWarning('optional param `type_` is deprecated, please use `mime_type` instead'))
50-
mime_type = type_
51-
5247
pattern = re.compile('\.([^.]*)$')
5348
extension = pattern.findall(name)
5449
if extension:
@@ -92,11 +87,7 @@ def query(cls):
9287
return leancloud.Query(cls)
9388

9489
@classmethod
95-
def create_with_url(cls, name, url, meta_data=None, mime_type=None, type_=None):
96-
if type_ is not None:
97-
warnings.warn('optional param `type_` is deprecated, please use `mime_type` instead')
98-
mime_type = type_
99-
90+
def create_with_url(cls, name, url, meta_data=None, mime_type=None):
10091
f = File(name, None, mime_type)
10192
if meta_data:
10293
f._metadata.update(meta_data)

leancloud/object_.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import time
88
import copy
99
import json
10-
import warnings
1110

1211
import iso8601
1312
from werkzeug import LocalProxy
@@ -83,20 +82,10 @@ def __init__(self, **attrs):
8382
self._attributes = {}
8483
self.created_at = None
8584
self.updated_at = None
86-
self._fetch_when_save = False
8785

8886
for k, v in iteritems(attrs):
8987
self.set(k, v)
9088

91-
@property
92-
def fetch_when_save(self):
93-
return self._fetch_when_save
94-
95-
@fetch_when_save.setter
96-
def fetch_when_save(self, value):
97-
warnings.warn('leancloud.Object.fetch_when_save is deprecated, please use leancloud.Object.save with param fetch_when_save instead.', leancloud.errors.LeanCloudWarning);
98-
self._fetch_when_save = value
99-
10089
@classmethod
10190
def extend(cls, name):
10291
"""
@@ -171,11 +160,6 @@ def destroy_all(cls, objs):
171160
ids = ','.join(ids)
172161
client.delete('/classes/{0}/{1}'.format(objs[0]._class_name, ids))
173162

174-
@property
175-
def attributes(self):
176-
warnings.warn('leancloud.Object.attributes should not be used any more, please use get or set instead', leancloud.errors.LeanCloudWarning)
177-
return self._attributes
178-
179163
def dump(self):
180164
obj = self._dump()
181165
obj.pop('__type')
@@ -227,8 +211,6 @@ def save(self, where=None, fetch_when_save=None):
227211
self._deep_save(unsaved_children, unsaved_files, exclude=self._attributes)
228212

229213
data = self._dump_save()
230-
if fetch_when_save is None:
231-
fetch_when_save = self.fetch_when_save
232214
fetch_when_save = 'true' if fetch_when_save else 'false'
233215

234216
if self.is_new():

leancloud/query.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from __future__ import print_function
66

77
import json
8-
import warnings
98

109
import leancloud
1110
from leancloud import client
@@ -91,10 +90,6 @@ def __init__(self, query_class):
9190
self._order = []
9291
self._select = []
9392

94-
def __call__(self):
95-
warnings.warn('leancloud.Relation.query now is a property, please don\'t call it as a function', LeanCloudWarning)
96-
return self
97-
9893
@classmethod
9994
def or_(cls, *queries):
10095
"""
@@ -399,10 +394,6 @@ def exists(self, key):
399394
self._add_condition(key, '$exists', True)
400395
return self
401396

402-
def does_not_exists(self, key):
403-
warnings.warn('the query does_not_exists is deprecated, please use does_not_exist instead', LeanCloudWarning)
404-
return self.does_not_exist(key)
405-
406397
def does_not_exist(self, key):
407398
"""
408399
增加查询条件,限制查询结果对象不包含指定字段
@@ -463,10 +454,6 @@ def does_not_match_query(self, key, query):
463454
self._add_condition(key, '$notInQuery', dumped)
464455
return self
465456

466-
def matched_key_in_query(self, key, query_key, query):
467-
warnings.warn('the query matched_key_in_query is deprecated, please use matches_key_in_query', LeanCloudWarning)
468-
return self.matches_key_in_query(key, query_key, query)
469-
470457
def matches_key_in_query(self, key, query_key, query):
471458
"""
472459
增加查询条件,限制查询结果对象指定字段的值,与另外一个查询对象的返回结果指定的值相同。

tests/test_engine.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ def test_current_user(): # type: () -> None
507507

508508
@engine.define
509509
def current_user():
510-
user = engine.current_user
510+
user = engine.current.user
511511
TestCurrentUser = leancloud.Object.extend('TestCurrentUser')
512512
o = TestCurrentUser()
513513
o.set('user', user)
@@ -532,7 +532,7 @@ def current_user():
532532

533533
@engine.before_save('Xxx')
534534
def before_xxx_save(xxx):
535-
assert engine.current_user.get('username') == saved_user.get('username')
535+
assert engine.current.user.get('username') == saved_user.get('username')
536536

537537
response = requests.post(url + '/__engine/1/functions/Xxx/beforeSave', headers={
538538
'x-avoscloud-application-id': TEST_APP_ID,

tests/test_file.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,10 @@ def test_basic(): # type: () -> None
3737
s1.write('blah blah blah')
3838
else:
3939
s1 = s
40-
f1 = File('Blah', s, mime_type='text/plain')
41-
f2 = File('Blah', s1, type_='text/plain')
42-
for f in (f1, f2):
43-
assert f.name == 'Blah'
44-
assert f._metadata['size'] == 14
45-
assert f.size == 14
40+
f = File('Blah', s, mime_type='text/plain')
41+
assert f.name == 'Blah'
42+
assert f._metadata['size'] == 14
43+
assert f.size == 14
4644

4745

4846
def test_create_with_url(): # type: () -> None

tests/test_query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def test_contains_all(): # type: () -> None
311311

312312
@with_setup(make_setup_func())
313313
def test_exist_and_does_not_exists(): # type: () -> None
314-
assert Query(GameScore).does_not_exists('oops').find()
314+
assert Query(GameScore).does_not_exist('oops').find()
315315
result = Query(GameScore).exists('playerName').find()
316316
assert len(result) == 10
317317

tests/test_relation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_query_relation(): # type: () -> None
5151

5252
album = leancloud.Query('Album').get(album.id)
5353
relation = album.relation('band')
54-
bands = relation.query().find()
54+
bands = relation.query.find()
5555
assert band1.id in [x.id for x in bands]
5656
assert band2.id in [x.id for x in bands]
5757

0 commit comments

Comments
 (0)