Merge pull request #465 from weakish/bugbear

bugbear

Author: weakish

.flake8

@@ -1,4 +1,6 @@
 [flake8]
-max-line-length = 88
-extend-ignore = E203
-exclude = build,docs
+ignore = E203, E266, E501, E722, W503
+max-line-length = 80
+max-complexity = 18
+select = B,C,E,F,W,T4,B9
+exclude = build,docs

.github/workflows/pythonpackage.yml

@@ -29,8 +29,8 @@ jobs:
         pip install -r requirements.txt
     - name: Lint with flake8
       run: |
-        pip install flake8
+        pip install flake8 flake8-bugbear
         # stop the build if there are Python syntax errors or undefined names
         flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        # exit-zero treats all errors as warnings.
+        flake8 . --count --exit-zero --statistics

leancloud/engine/leanengine.py

@@ -185,7 +185,7 @@ def dispatch_request(self, environ):
             return Response(json.dumps(result), mimetype="application/json")
         except LeanEngineError as e:
             return Response(
-                json.dumps({"code": e.code, "error": e.message}),
+                json.dumps({"code": e.code, "error": e.message}),  # noqa: B306
                 status=e.code if e.code else 400,
                 mimetype="application/json",
             )

leancloud/file_.py

@@ -100,8 +100,8 @@ def __init__(self, name="", data=None, mime_type=None):
         self._source = data
 
     @utils.classproperty
-    def query(cls):
-        return leancloud.Query(cls)
+    def query(self):
+        return leancloud.Query(self)
 
     @classmethod
     def create_with_url(cls, name, url, meta_data=None, mime_type=None):

leancloud/object_.py

@@ -24,12 +24,12 @@
 
 
 class ObjectMeta(type):
-    def __new__(cls, name, bases, attrs):
+    def __new__(mcs, name, bases, attrs):
         cached_class = object_class_map.get(name)
         if cached_class:
             return cached_class
 
-        super_new = super(ObjectMeta, cls).__new__
+        super_new = super(ObjectMeta, mcs).__new__
 
         # let user define their class_name at subclass-creation stage
         class_name = attrs.pop("class_name", None)
@@ -51,7 +51,7 @@ def __new__(cls, name, bases, attrs):
         else:
             attrs["_class_name"] = name
 
-        object_class = super_new(cls, name, bases, attrs)
+        object_class = super_new(mcs, name, bases, attrs)
         object_class_map[name] = object_class
         return object_class
 
@@ -168,7 +168,7 @@ def destroy_all(cls, objs):
         response = client.post("/batch", params={"requests": dumped_objs}).json()
 
         errors = []
-        for idx, obj in enumerate(objs):
+        for idx in range(len(objs)):
             content = response[idx]
             error = content.get("error")
             if error:

leancloud/query.py

@@ -30,6 +30,7 @@ class CQLResult(object):
 
         class_name: 查询的 class 名称
     """
+    __slots__ = ["results", "count", "class_name"]
 
     def __init__(self, results, count, class_name):
         self.results = results

leancloud/user.py

@@ -311,12 +311,12 @@ def is_authenticated(self):
         return response.status_code == 200
 
     @classmethod
-    def request_password_reset(self, email):
+    def request_password_reset(cls, email):
         params = {"email": email}
         client.post("/requestPasswordReset", params)
 
     @classmethod
-    def request_email_verify(self, email):
+    def request_email_verify(cls, email):
         params = {"email": email}
         client.post("/requestEmailVerify", params)
 

tests/test_query.py

@@ -87,7 +87,7 @@ def match_key_setup():
         for k in old2:
             k.destroy()
 
-        for i in range(5):
+        for _i in range(5):
             for k in range(10):
                 a = A()
                 a.set("age", k)