make sending a confirmation email for requested evaluations to teachers optional#74
Open
irinahpe wants to merge 3 commits into
Open
make sending a confirmation email for requested evaluations to teachers optional#74irinahpe wants to merge 3 commits into
irinahpe wants to merge 3 commits into
Conversation
…luations to teachers optional
Laur0r
reviewed
Sep 20, 2023
Contributor
Laur0r
left a comment
There was a problem hiding this comment.
Nice work, thanks! Only two small things, it would be good to have an additional help button explaining under what circumstances emails are sent to teachers (only when the evaluation is requested from the overview page). Second, for existing categories the checkbox is set to false not true, maybe you can have another look at that.
Contributor
Author
|
I added the help button and changed the default values also in the db-tables. But since the default values are saved as the persistent properties mode_flags in the evasys_category and the evasys_category is only created after the category has been added to evasys in the admin settings, it is not possible to change the dafault values afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evasys-managers can now choose wether to have an email sent to teachers of the course of which they started an evaluation on