Update for Moodle 5.0#47
Conversation
|
I have rebased the changes onto main and re-arranged some commits. I |
|
As discussed with @bluetom and @TamaroWalter I have removed two commits and pushed a v3 of this branch. We agreed on making the code checker ignore the thirdparty/ code since it violates Moodle coding standards anyway so there is no point in checking for it. @TamaroWalter will adapt the central Learnweb workflow files to make this work. Since we want to support 4.1 for a couple of weeks, we cannot upgrade the |
|
I have just noticed that the problems do not arise with the code checker. The |
|
I have found a way to make PHPUnit ignore deprecations in third-party code in the docs. I tested this locally and had to adapt Moodle's sed -i 's/<source>/<source ignoreIndirectDeprecations="true">/' /var/www/html/phpunit.xml.distThen running However, scanning through the moodle-plugin-ci source, it might be possible to simply place a |
|
Okay, I'll try it |
|
@TamaroWalter, could you please move add new admin setting for custom host name (bb9b361) into a new PR for issue #55? I am tackling #52. |
f7fbf04 to
c46ecc5
Compare
13e9246 to
0683bb2
Compare
This PR adapts the repo to the new changes of Moodle 5.0.
Changes made:
Todo's: