RuneScape has been updated! Please reload this page.

[CursedSilicon]

Hi team,

I built the latest Client from source and tried connecting to a LostCityRS (Formally 2004scape) server.

Despite setting the server to run Build 225, when connecting I get a "RuneScape has been updated! Please reload this page." response from the client instead.

I'm not clear if this is an issue with the client or the server at this time. However setting the server to a newer build causes the client to simply fail at connecting to the server. So I believe it may be the client

[lesleyrs]

Fixed, whenever the server makes cache changes the desktop client needs a manual update. Currently only the 2 webclient builds actually download the cache so they don't encounter this issue, but I didn't expect cache to change this often. Downloading should probably be added at some point but won't work for all console platforms. I added a better error msg for now (can be ignored if login is successful).

It should work with the latest lostcity 225 server as of now. a5fe140

[CursedSilicon]

Sorry for the delayed response, I've been absolutely ruined by flu. I'll check this out later this week!

Thank you for being so prompt on this issue ❤️

[CursedSilicon]

Sorry for the delay.

I git cloned the latest build, built it and tried firing it up on my machine

I'm still getting the same "Runescape has been updated!" error. In the console I'm seeing a lot of "CRC check failed" and "TODO downloading" messages however?

[lesleyrs]

Did you update the server as well? If you run start on the server u can select update source and that should fix it, it works for me right now. The non-webclient builds right now just work on the latest server as they changed cache recently.

[CursedSilicon]

I was using the build from a few weeks ago.

Git cloned a fresh copy just now and set it up as a 225 build. Set the default setup flags (single world, register on login etc)

Took about 30 seconds for the server to do the "cache packing"

Started client after that. Tried to log in as a test user. Exact same "Runescape has been updated!" message as in the screenshot above unfortunately :(

[lesleyrs]

I just tried a fresh 225 server and client like you did and the archive checksums match correctly.

src/entry/client.c line 179 in the client

        c->archive_checksum[0] = 0;
        c->archive_checksum[1] = 784449929;
        c->archive_checksum[2] = -1494598746;
        c->archive_checksum[3] = 1614084464;
        c->archive_checksum[4] = 855958935;
        c->archive_checksum[5] = -2000991154;
        c->archive_checksum[6] = -313801935;
        c->archive_checksum[7] = 1570981179;
        c->archive_checksum[8] = -1532605973;

You can confirm if the server matches by logging the crc values when starting the server in makeCrc:

engine/src/cache/CrcTable.ts in the server

    const crc = Packet.getcrc(packet.data, 0, packet.data.length);
    console.log(crc);

If they don't match you can add the servers values to the clients archive_checksum and it will work!

I'm not sure why they wouldn't be matching for you though considering I also just re-did cache packing and was able to log in. Maybe you didn't update the client on windows xp?

It's not your fault btw, I should probably finish this issue.

[CursedSilicon]

I think that might be a lead. Or at least a bug (possibly in LostCityRS itself?)

One of mine is coming back with a different checksum for...some reason? I don't actually know why. Maybe some weird platform quirk in the server I'm running it on using Gentoo?

Every single other one is the same except one

784449929
-1494598746
1614084464
-676019321
-2000991154
-313801935
1570981179
-1532605973

I rebuilt it with these checksums included. But I'm still getting the same errors as above. Including the "archive CRC check failed"

Interestingly, even if I start the client without the server running, it trips over the same "CRC check failed " type error

[lesleyrs]

You can completely ignore the error message in the client, it's just there to tell you what I just said above. You're able to login and play even if cache is "different" you just need to set the correct checksums in the client. (The client is comparing the cache with the hardcoded checksums, not the server which is the issue right now) The java client would work no problem.

Make sure you changed the archive_checksums in client.c and not playground.c which should fix your login fail.

If nothing works you could simply just comment out 3 lines in the server engine/src/engine/World.ts line 2155

            if (CrcBuffer32 !== Packet.getcrc(crcs, 0, crcs.length)) {
                // client.send(Uint8Array.from([6]));
                // client.close();
                // return;
            }

as temporary fix to skip the login check. This should work as I just tried it.

[CursedSilicon]

I tried changing the "incorrect" hard-coded line I found in src/entry/client.c (I don't know if that checksum error is something to be concerned about upstream with LostCityRS also?) but it still gave the "Runescape has been updated!" message after re-compiling the app and copying it back to the XP machine for testing.

I'll try commenting out the lines above you provided when I'm at my workshop again (likely tomorrow or Sunday) and report back. Fingers crossed!

[lesleyrs]

I tried changing the "incorrect" hard-coded line I found in src/entry/client.c (I don't know if that checksum error is something to be concerned about upstream with LostCityRS also?) but it still gave the "Runescape has been updated!" message after re-compiling the app and copying it back to the XP machine for testing.

Yes that alone should have fixed it, even if your checksums magically differ from mine then it should still work if you changed the client. The error isn't related to lostcity other than them changing the cache.

If you really wanted to figure out whats wrong you could just log the connection in the server, it starts in engine/src/server/tcp/TcpServer.ts and your issue is in engine/src/engine/World.ts onClientData.

[CursedSilicon]

The error isn't related to lostcity other than them changing the cache.

What I mean is. (if I understand correctly) the cache checksums should be the same across both yours and my deployments of it, since they're both the same 225 Runescape build.

If it's still throwing errors after I patch out the login check I'll set up more logging and go from there

[CursedSilicon]

Did a fresh git clone of both Client3 and LostCityRS just as a sanity check

Applied the CRC value change in the client. Still got the "Runescape has been updated!" weirdness

Added the login skip check aaaand...it worked, immediately!

Not sure what the root cause of the differences are. But at least it's working!

[lesleyrs]

Great, yea your platform definitely has a different cache packing result than my ubuntu.

You could create an issue there or let Pazaz know about this but to be fair it's probably not a big priority for him, since it's not noticeable on other clients.

The packed client cache is in engine/data/pack/client and caused by the media file specifically, if you send that file to him it would help.

Changing the client crcs as it is without the skip should've still worked, not sure what's up with that (maybe a typo like missing the minus). Regardless I'll reopen this for now so people can be aware of it.