feat: when defaultMode is set to allowAll, "unknown" scope permissions should be allowed by default.

Author: qorzj

packages/core/src/common/permissions.ts

@@ -273,7 +273,7 @@ export function evaluatePermissionScopes(
     defaultMode: "allowAll",
   }
 ): PermissionDecision {
-  if (scopes.includes("unknown")) {
+  if (scopes.includes("unknown") && settings.defaultMode !== "allowAll") {
     return "ask";
   }
   if (scopes.length === 0) {
@@ -304,7 +304,9 @@ export function getPermissionScopesRequiringAsk(
   const result: AskPermissionScope[] = [];
   for (const scope of scopes) {
     if (scope === "unknown") {
-      result.push(scope);
+      if (settings.defaultMode !== "allowAll") {
+        result.push(scope);
+      }
       continue;
     }
     if (settings.deny.includes(scope)) {

packages/core/src/tests/permissions.test.ts

@@ -7,6 +7,7 @@ import {
   appendProjectPermissionAllows,
   computeToolCallPermissions,
   evaluatePermissionScopes,
+  getPermissionScopesRequiringAsk,
   hasUserPermissionReplies,
   isPathInAnyDirectory,
   parseBashSideEffects,
@@ -46,6 +47,47 @@ test("evaluatePermissionScopes applies deny, ask, allow, and default mode preced
   assert.equal(evaluatePermissionScopes(["unknown"], settings), "ask");
 });
 
+test("evaluatePermissionScopes allows unknown when defaultMode is allowAll", () => {
+  const allowAllSettings = {
+    allow: [] as const,
+    deny: [] as const,
+    ask: [] as const,
+    defaultMode: "allowAll" as const,
+  };
+  assert.equal(evaluatePermissionScopes(["unknown"], allowAllSettings), "allow");
+
+  // unknown + other scopes that would otherwise trigger ask should still ask for those scopes
+  const askNetworkSettings = {
+    allow: [] as const,
+    deny: [] as const,
+    ask: ["network" as const],
+    defaultMode: "allowAll" as const,
+  };
+  assert.equal(evaluatePermissionScopes(["unknown", "network"], askNetworkSettings), "ask");
+});
+
+test("getPermissionScopesRequiringAsk excludes unknown when defaultMode is allowAll", () => {
+  const allowAllSettings = {
+    allow: [] as const,
+    deny: [] as const,
+    ask: ["network" as const],
+    defaultMode: "allowAll" as const,
+  };
+  const result = getPermissionScopesRequiringAsk(["unknown", "network"], allowAllSettings);
+  assert.deepEqual(result, ["network"]);
+});
+
+test("getPermissionScopesRequiringAsk includes unknown when defaultMode is askAll", () => {
+  const askAllSettings = {
+    allow: [] as const,
+    deny: [] as const,
+    ask: ["network" as const],
+    defaultMode: "askAll" as const,
+  };
+  const result = getPermissionScopesRequiringAsk(["unknown", "network"], askAllSettings);
+  assert.deepEqual(result, ["unknown", "network"]);
+});
+
 test("computeToolCallPermissions maps tool calls to permission requests", () => {
   const projectRoot = createTempDir("deepcode-permissions-workspace-");
   const plan = computeToolCallPermissions({