local only libfdata_list_element_initialize used in tests?

[xambroz]

Hello,
the functions libfdata_list_element_initialize and libfdata_list_element_free are not part of the header files, which are installed to the /usr/include/libfdata*

The libfdata_list_element_initialize/free are used for example in the "make check" of libregf:

libtool: link: gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,pack-relative-relocs -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes -o .libs/regf_test_hive_bin_header regf_test_functions.o regf_test_hive_bin_header.o regf_test_memory.o  ../libregf/.libs/libregf.so -lcthreads -lcdata -lclocale -lcnotify -lcsplit -luna -lcfile -lcpath -lbfio -lfcache -lfdata -lfdatetime -lfwnt -lcerror -ldl
gcc -DHAVE_CONFIG_H -I. -I../common  -I../include -I../include -I../common -I../common    -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wall -c -o regf_test_hive_bins_list.o regf_test_hive_bins_list.c
regf_test_hive_bins_list.c: In function ‘regf_test_hive_bins_list_read_element_data’:
regf_test_hive_bins_list.c:1639:18: error: implicit declaration of function ‘libfdata_list_element_initialize’; did you mean ‘libfdata_stream_initialize’? [-Wimplicit-function-declaration]
 1639 |         result = libfdata_list_element_initialize(
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                  libfdata_stream_initialize
regf_test_hive_bins_list.c:1866:18: error: implicit declaration of function ‘libfdata_list_element_free’; did you mean ‘libfdata_list_is_element_set’? [-Wimplicit-function-declaration]
 1866 |         result = libfdata_list_element_free(
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                  libfdata_list_is_element_set
make[2]: *** [Makefile:1631: regf_test_hive_bins_list.o] Error 1

[xambroz]

Sorry not sure if this is issue to libfdata or libregf.

[joachimmetz]

Tests are WIP, why do you need the tests to work with shared version of libfdata?

[xambroz]

Tests are WIP

Sure, I am not saying it is urgent, but when I learned about the condition I am letting you know as good citizen

why do you need the tests to work with shared version of libfdata?

In general I am trying to repack libyal libraries according to Fedora packaging standard ... and Fedora rules require that what is possible to unbundle, it should be unbundled so in case of some security vulnerability it can be fixed on one place and know the packages affected

[xambroz]

BTW the "make check" will fail even with the release bundled version in libregf