Commit f47da8b
refactor(cef): re-import clean CEF 147 headers; source generated headers from CEF_ROOT
The vendored src/include tree had drifted from upstream: a stale
internal/cef_types.h missing the CEF 147 CEF_API_ADDED(14700) ABI content
(new result codes, permission types, CPAIT enums) while the build links the
147 binary, plus AI cosmetic edits (em-dashes, license reflow), removed-upstream
headers (cef_extension*, base/cef_callback_list, cef_auto_reset, cef_ptr_util,
cef_tuple, ...), and checked-in generated release headers.
Re-import src/include cleanly from the upstream CEF source repository at the
exact build commit (chromiumembedded/cef@d58e84d = 147.0.10+gd58e84d), verified
byte-identical to all three platform binary distributions (Linux/macOS exact;
Windows exact after CRLF normalization).
The platform-generated headers are intentionally NOT vendored (they are produced
during CEF packaging and differ per platform): cef_version.h, cef_config.h,
cef_api_versions.h, cef_color_ids.h, cef_command_ids.h, cef_pack_resources.h,
cef_pack_strings.h, and base/internal/cef_net_error_list.h. They are still
required at compile time because upstream headers include them transitively
(e.g. cef_browser.h -> cef_command_ids.h; cef_api_hash.h -> cef_version.h;
cef_types.h -> cef_net_error_list.h), so they are now resolved from
CEF_ROOT/include:
- CMake lists CEF_ROOT after src/ on the include path (module, client_handler,
cpp_utils, subprocess) so vendored source headers take precedence and only the
generated headers fall through to the CEF SDK.
- automate.py --prebuilt-cef copies include/ into the prebuilt CEF_ROOT so it is
a complete SDK; the copy is idempotent so a CI-cached prebuilt dir created
before this change is repaired.
Also removes the unused capi/ headers and documents the reproducible header
re-import procedure in docs/Contributing-code.md ("Updating CEF version") so
future upgrades stay clean.
Verified on Linux: clean build, 85/85 unit tests, hello_world. Windows/macOS
rely on CI; their headers were verified byte-identical to the respective dists.
Addresses review feedback on PR cztomczak#691 (cztomczak/cefpython).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent f722886 commit f47da8b
31 files changed
Lines changed: 239 additions & 22615 deletions
File tree
- docs
- src
- client_handler
- cpp_utils
- include
- base
- internal
- internal
- subprocess
- tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
255 | 261 | | |
256 | 262 | | |
257 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
This file was deleted.
0 commit comments