Address Copilot remarks

Author: mawilk90

test/integration/conftest.py

@@ -16,7 +16,9 @@
 from requests.exceptions import ConnectionError, RequestException
 
 from linode_api4 import (
+    Instance,
     InterfaceGeneration,
+    IPAddress,
     LinodeInterfaceDefaultRouteOptions,
     LinodeInterfaceOptions,
     LinodeInterfacePublicOptions,
@@ -761,14 +763,15 @@ def create_reserved_ip_assigned(test_linode_client, create_linode):
         region=linode.region,
     )
 
+    linode = client.load(Instance, linode.id)
     reserved_ip = test_linode_client.load(
         ReservedIPAddress, reserved_ip.address
     )
 
     yield linode, reserved_ip
 
-    # Delete only if IP exists (some tests delete it earlier)
-    if client.networking.reserved_ips(
-        ReservedIPAddress.address == reserved_ip.address
+    # Delete assigned IP address completely
+    if address := client.networking.ips(
+        IPAddress.address == reserved_ip.address
     ):
-        reserved_ip.delete()
+        address[0].delete()

test/integration/models/networking/test_networking.py

@@ -514,6 +514,12 @@ def test_create_reserved_ip_with_allocate(
     reserved_ip = client.load(ReservedIPAddress, reserved_ip.address)
     reserved_ip.delete()
 
+    # Delete assigned IP address completely
+    if address := client.networking.ips(
+        IPAddress.address == reserved_ip.address
+    ):
+        address[0].delete()
+
 
 def test_reserve_ephemeral_ip(test_linode_client, create_linode):
     client = test_linode_client

test/integration/models/nodebalancer/test_nodebalancer.py

@@ -129,7 +129,6 @@ def test_create_nb_with_reserved_ip(
         ipv4=reserved_ip.address,
     )
 
-    assert TEST_REGION, nb.region
     assert label == nb.label
     assert nb.ipv4.address == reserved_ip.address
     assert nb.ipv4.public == True

test/integration/models/tag/test_tag.py

@@ -45,7 +45,7 @@ def test_get_tag_with_reserved_ip(
     tag, reserved_ip = create_tag_with_reserved_ip
     tag = test_linode_client.load(Tag, tag.id).objects[0]
 
-    assert vars(tag).keys() == vars(reserved_ip).keys()
+    assert isinstance(tag, ReservedIPAddress)
     assert tag.address == reserved_ip.address
     assert tag.reserved == reserved_ip.reserved
     assert tag.tags == reserved_ip.tags