From b9f377baf6a5bd774f7d239fac31729c70b14d4d Mon Sep 17 00:00:00 2001 From: Thorsten Blum Date: Tue, 12 May 2026 14:46:28 +0200 Subject: [PATCH] riscv: propagate insert_resource result from add_resource Currently, add_resource() returns 1 on success, even though its callers only check for negative values. Instead, propagate the insert_resource() result from add_resource() to align with standard kernel return-value conventions (0 on success, negative errno on failure). Signed-off-by: Thorsten Blum Signed-off-by: Linux RISC-V bot --- arch/riscv/kernel/setup.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c index c89cc272440b9f..6e3d8acae71a56 100644 --- a/arch/riscv/kernel/setup.c +++ b/arch/riscv/kernel/setup.c @@ -71,16 +71,14 @@ static struct resource *standard_resources; static int __init add_resource(struct resource *parent, struct resource *res) { - int ret = 0; + int ret; ret = insert_resource(parent, res); - if (ret < 0) { + if (ret < 0) pr_err("Failed to add a %s resource at %llx\n", res->name, (unsigned long long) res->start); - return ret; - } - return 1; + return ret; } static int __init add_kernel_resources(void)