I don't think we need to do this for now, but I this issue is to document relevant changes.
I tested and vl-convert 2.0.0-rc1 fixes #3, so we can revert e74851a. I tested with the original reproduction and it is indeed fixed (I also checked that I could still reproduce the failure prior to e74851a).
vl-convert also updated v8 dependency and that causes build issues on linux. The Rust v8 package has precompiled static libraries, however those now cause issues when compiling into a shared library, which we do. vl-convert also has Python bindings, where they precompile a shared library, just like we do, so they run into the same issue. See the upstream PR (search for "V8 Position-Independent Code (fPIC)" in the description) and more detailed notes here. Making it work on linux requires compiling V8 from source by setting V8_FROM_SOURCE=1 and GN_ARGS as part the linked documentation, it has a few build dependencies such as clang. Given that V8 is rather huge, it takes a long time to build, even more so on CI. For this reason, I think we can wait with upgrading, unless we have a specific reason to do that.
I don't think we need to do this for now, but I this issue is to document relevant changes.
I tested and vl-convert 2.0.0-rc1 fixes #3, so we can revert e74851a. I tested with the original reproduction and it is indeed fixed (I also checked that I could still reproduce the failure prior to e74851a).
vl-convert also updated v8 dependency and that causes build issues on linux. The Rust v8 package has precompiled static libraries, however those now cause issues when compiling into a shared library, which we do. vl-convert also has Python bindings, where they precompile a shared library, just like we do, so they run into the same issue. See the upstream PR (search for "V8 Position-Independent Code (fPIC)" in the description) and more detailed notes here. Making it work on linux requires compiling V8 from source by setting
V8_FROM_SOURCE=1andGN_ARGSas part the linked documentation, it has a few build dependencies such as clang. Given that V8 is rather huge, it takes a long time to build, even more so on CI. For this reason, I think we can wait with upgrading, unless we have a specific reason to do that.