Remove second arg to init/LogSink

Author: alan-george-lk

.github/workflows/builds.yml

@@ -58,7 +58,7 @@ env:
   # failing the build.
   SCCACHE_GHA_ENABLED: "true"
   # Pinned commit for cpp-example-collection smoke build (https://github.com/livekit-examples/cpp-example-collection)
-  CPP_EXAMPLE_COLLECTION_REF: 56815733a71c14692569e8adf2916a56a14d4882
+  CPP_EXAMPLE_COLLECTION_REF: 361237b7dc52e939b0572aac14cc792678c5cc40
   # vcpkg binary caching for Windows
   VCPKG_DEFAULT_TRIPLET: x64-windows-static-md
   VCPKG_DEFAULT_HOST_TRIPLET: x64-windows-static-md

.github/workflows/docker-validate.yml

@@ -11,7 +11,7 @@ permissions:
 
 env:
   # Pinned commit for cpp-example-collection smoke build (https://github.com/livekit-examples/cpp-example-collection)
-  CPP_EXAMPLE_COLLECTION_REF: 56815733a71c14692569e8adf2916a56a14d4882
+  CPP_EXAMPLE_COLLECTION_REF: 361237b7dc52e939b0572aac14cc792678c5cc40
 
 jobs:
   validate-x64:

cpp-example-collection

@@ -44,25 +44,16 @@
 /// @brief Public API for the LiveKit C++ Client SDK.
 namespace livekit {
 
-/// The log sink to use for SDK messages.
-enum class LogSink {
-  /// Log messages to the console.
-  kConsole = 0,
-  /// Log messages to a callback function.
-  kCallback = 1,
-};
-
 /// Initialize the LiveKit SDK.
 ///
 /// This **must be the first LiveKit API called** in the process.
 /// It configures global SDK state, including log routing.
 ///
 /// @param level     Minimum log level for SDK messages (default: Info).
 ///                  Use setLogLevel() to change at runtime.
-/// @param log_sink  The log sink to use for SDK messages (default: Console).
 /// @returns true if initialization happened on this call, false if it was
 ///          already initialized.
-LIVEKIT_API bool initialize(const LogLevel& level = LogLevel::Info, const LogSink& log_sink = LogSink::kConsole);
+LIVEKIT_API bool initialize(const LogLevel& level = LogLevel::Info);
 
 /// Shut down the LiveKit SDK.
 ///

docs/doxygen/index.md

@@ -21,11 +21,11 @@
 
 namespace livekit {
 
-bool initialize(const LogLevel& level, const LogSink& log_sink) {
+bool initialize(const LogLevel& level) {
   // Initializes logger if singleton instance is not already initialized
   setLogLevel(level);
-  auto& ffi_client = FfiClient::instance();
-  return ffi_client.initialize(log_sink == LogSink::kCallback);
+  // Note: capture_logs currently disabled, requires event support in FfiClient
+  return FfiClient::instance().initialize(false);
 }
 
 bool isInitialized() { return FfiClient::instance().isInitialized(); }

include/livekit/livekit.h

@@ -456,7 +456,7 @@ class StressTestStats {
 class LiveKitTestBase : public ::testing::Test {
 protected:
   void SetUp() override {
-    livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
+    livekit::initialize(livekit::LogLevel::Info);
     config_ = TestConfig::fromEnv();
 
     // Tracing is controlled by compile-time macro LIVEKIT_TEST_ENABLE_TRACING

src/livekit.cpp

@@ -23,7 +23,7 @@ namespace livekit::test {
 class RoomTest : public ::testing::Test {
 protected:
   void SetUp() override {
-    livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
+    livekit::initialize(livekit::LogLevel::Info);
 
     const char* url_env = std::getenv("LIVEKIT_URL");
     const char* token_env = std::getenv("LIVEKIT_TOKEN_A");

src/tests/common/test_common.h

@@ -93,7 +93,7 @@ std::string generateRandomPayload(size_t size) {
 class RpcIntegrationTest : public ::testing::Test {
 protected:
   void SetUp() override {
-    livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
+    livekit::initialize(livekit::LogLevel::Info);
     config_ = RpcTestConfig::fromEnv();
   }
 

src/tests/integration/test_room.cpp

@@ -27,7 +27,7 @@ namespace livekit::test {
 
 class AudioFrameStressTest : public ::testing::Test {
 protected:
-  void SetUp() override { livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole); }
+  void SetUp() override { livekit::initialize(livekit::LogLevel::Info); }
 
   void TearDown() override { livekit::shutdown(); }
 };