address feedback

Author: stephen-derosa

src/local_audio_track.cpp

@@ -37,6 +37,10 @@ proto::OwnedTrack createAudioTrackWithSourceHandle(const std::string& name, std:
   msg->set_source_handle(source_handle);
 
   const proto::FfiResponse resp = FfiClient::instance().sendRequest(req);
+  if (!resp.has_create_audio_track()) {
+    // TODO(sderosa): we dont have an error code/return, is throwing ok?
+    throw std::runtime_error("create_audio_track response is missing track");
+  }
   return resp.create_audio_track().track();
 }
 

src/platform_audio.cpp

@@ -177,8 +177,18 @@ std::shared_ptr<PlatformAudioSource> PlatformAudio::createAudioSource(const Plat
     throw PlatformAudioError("FfiResponse missing new_audio_source");
   }
 
-  const auto& source = resp.new_audio_source().source();
-  FfiHandle handle(static_cast<uintptr_t>(source.handle().id()));
+  const auto& new_source = resp.new_audio_source();
+  if (!new_source.has_source() || !new_source.source().has_handle()) {
+    throw PlatformAudioError("NewAudioSourceResponse missing source handle");
+  }
+
+  const auto& source = new_source.source();
+  const std::uint64_t handle_id = source.handle().id();
+  if (handle_id == 0) {
+    throw PlatformAudioError("NewAudioSourceResponse returned an invalid (null) source handle");
+  }
+
+  FfiHandle handle(static_cast<uintptr_t>(handle_id));
   return std::shared_ptr<PlatformAudioSource>(new PlatformAudioSource(std::move(handle), state_));
 }