Skip to content

FOLLOW-UP: Add test job before release builds #126

@adnaan

Description

@adnaan

Context

This follow-up task was identified during the review of PR #122.

Source PR: #122
PR Title: feat: add CLI release workflow and Homebrew support
Suggested by: @claude[bot]

Task Description

The CLI release workflow currently builds and releases without running tests first. Add a test job that must pass before builds proceed.

Implementation

Add to .github/workflows/cli-release.yml:

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-go@v5
        with:
          go-version: ${{ env.GO_VERSION }}
          cache: true
      - run: GOWORK=off go test -short ./internal/...
  
  build:
    needs: [test]  # Add this dependency
    # ... rest of build job

Benefits

  • Prevents releasing broken code
  • Catches regressions before they reach users
  • Minimal overhead (tests run in parallel with build setup)

This issue was automatically created by prmonitor from PR review comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1-highHigh: release readiness, core UX, adoptionenhancementNew feature or requestfollow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions