Skip to content

Is there something missing in dphs derivation? #4

@pg2455

Description

@pg2455

Hi,

Current formulation of dphs is

dphs = np.dot(dc, self.c)[:self.ys] + np.dot(do, self.o)[:self.ys] + np.dot(di, self.i)[:self.ys] + np.dot(df, self.f)[:self.ys] 

I think it should be:

dphs = np.dot(dc * self.dtangent(c), self.c)[:self.ys] + np.dot(do * self.dtangent(o), self.o)[:self.ys] + \
                 np.dot(di * self.dtangent(i), self.i)[:self.ys] + np.dot(df * self.dtangent(f), self.f)[:self.ys]

dtangent is missing from the derivation. Is that correct?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions