review wording

Author: llegaz

src/RedisCache.php

@@ -38,6 +38,8 @@
  *
  * @package RedisCache
  * @author Laurent LEGAZ <laurent@legaz.eu>
+ * @version 1.0
+ * @see https://redis.io/docs/latest/develop/data-types/#strings Redis Strings documentation
  */
 class RedisCache extends RedisAdapter implements CacheInterface
 {
@@ -462,9 +464,9 @@ protected function checkKeyValidity(mixed &$key): void
         }
 
         /**
-         *filter also common forbidden characters between URL RFC and PSR-6/16 key definition
-         * that is those 3: <code>\{}</code>, backslash and curly brackets
-         * we use square brackets in IPv6 based URLs...
+         * We filter also common forbidden characters between URL RFC and PSR-6/16 key definition,
+         * that is those 3 chars: <code>\{}</code>, backslash and curly brackets.
+         * We keep square brackets for use in IPv6 based URLs...
          *
          */
         if (preg_match('/[\\\\{}]/', $key)) {

src/RedisEnhancedCache.php

@@ -74,7 +74,7 @@
  * @author Laurent LEGAZ <laurent@legaz.eu>
  * @version 1.0
  * @see RedisCache Parent class providing base Redis functionality
- * @see https://redis.io/docs/data-types/hashes/ Redis Hash documentation
+ * @see https://redis.io/docs/latest/develop/data-types/#hashes Redis Hash documentation
  */
 class RedisEnhancedCache extends RedisCache
 {
@@ -96,16 +96,9 @@ class RedisEnhancedCache extends RedisCache
      * Stores multiple key-value pairs in a specified Redis Hash pool.
      *
      * This method allows batch insertion of cache entries into a named pool using Redis Hash operations.
-     * All values are automatically serialized before storage to ensure consistency. The method uses
-     * HMSET for multiple values and HSET for single values to optimize Redis operations.
-     *
-     * <b>Behavior:</b>
-     * - For multiple values (count > 1): Uses Redis HMSET command
-     * - For single value (count === 1): Uses Redis HSET command
-     * - For empty array: Returns false without Redis operation
+     * All values are automatically serialized before storage to ensure consistency.
      *
      * <b>Data Processing:</b>
-     * - Keys are validated against PSR compliance rules (except for the ":" character which is accepted)
      * - Values are serialized using internal serialization mechanism
      * - Both keys and values undergo validation before storage
      *
@@ -193,15 +186,8 @@ public function storeToPool(array $values, string $pool = self::DEFAULT_POOL): b
      *
      * All retrieved values are automatically unserialized to restore their original data types.
      *
-     * <b>Return Behavior:</b>
-     * - Single key (string/int): Returns the value or DOES_NOT_EXIST constant
-     * - Multiple keys (array): Returns associative array of key => value pairs
-     * - Non-existent keys: Replaced with DOES_NOT_EXIST constant in results
-     * - Invalid parameters: Throws InvalidKeyException
-     *
      * <b>Data Processing:</b>
      * - Values are automatically deserialized upon retrieval
-     * - String values are converted back to their original types
      * - Missing values are marked with DOES_NOT_EXIST constant
      * - Array results maintain key association from input
      *
@@ -273,12 +259,6 @@ public function fetchFromPool(mixed $key, string $pool = self::DEFAULT_POOL): mi
      * which is useful for conditional logic and validation operations. It uses Redis HEXISTS
      * command for optimal performance.
      *
-     * <b>Implementation Notes:</b>
-     * - Uses native Redis HEXISTS command for efficiency
-     * - Handles adapter differences between php-redis and predis clients
-     * - php-redis returns boolean true/false
-     * - predis returns integer 1/0
-     * - Both are normalized to boolean return value
      *
      * <b>Usage Examples:</b>
      * <code>
@@ -339,7 +319,6 @@ public function hasInPool(string $key, string $pool = self::DEFAULT_POOL): bool
      *
      * <b>Behavior:</b>
      * - Uses Redis HDEL for atomic deletion
-     * - All keys are validated before deletion attempt
      * - Non-existent keys are silently ignored (not treated as errors)
      * - Returns true if Redis operation succeeds (even if some keys didn't exist)
      *
@@ -455,6 +434,10 @@ public function setHsetPoolExpiration(string $pool = self::DEFAULT_POOL, int $ex
         $redisResponse = -1;
 
         if ($expirationTime > 0) {
+            /**
+             * <b>CRITICAL WARNING:</b>
+             * Expiration applies to the ENTIRE pool !
+             */
             $redisResponse = $this->getRedis()->expire($pool, $expirationTime);
         }